Details

Reviewers

Commits

R1:413a8da819e2: fix: create daemons without using reference to instance

Summary

We should supply any necessary information from the instance during the daemon run iteration, rather than saving information from the instance.

Test Plan

N/A

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rexledesma created this revision.Jun 3 2021, 5:58 PM

Harbormaster completed remote builds in B31611: Diff 38914.Jun 3 2021, 6:20 PM

rexledesma requested review of this revision.Jun 3 2021, 6:20 PM

rexledesma retitled this revision from Pass in same reference to instance when creating daemons to Create daemons without using reference to instance.Jun 3 2021, 7:34 PM

rexledesma edited the summary of this revision. (Show Details)

thanks for doing this! One small thing and we're good I think (let's merge create() with the constructor)

python_modules/dagster/dagster/daemon/daemon.py
53–58	I don't see the value of this method - can we call the constructor directly?

This revision now requires changes to proceed.Jun 3 2021, 7:36 PM

Harbormaster failed remote builds in B31628: Diff 38939!Jun 3 2021, 7:49 PM

rexledesma added a child revision: Restricted Differential Revision.Jun 9 2021, 10:57 PM

Harbormaster failed remote builds in B31927: Diff 39328!Jun 9 2021, 11:15 PM

rexledesma retitled this revision from Create daemons without using reference to instance to fix: create daemons without using reference to instance.Jun 10 2021, 1:23 PM

dgibson accepted this revision.Jun 11 2021, 2:36 PM

This revision is now accepted and ready to land.Jun 11 2021, 2:36 PM

probably will require a quick internal change too right?