Branch LogsProvider to use a polling query in cases where the websocket is not open. The query uses after to retrieve slices of logs.
Depends on https://dagster.phacility.com/D8220.
Differential D8224
[dagit] Add a polling query for Run logs • dish on Jun 3 2021, 5:23 PM. Authored by Tags None Referenced Files
Subscribers None
Details Branch LogsProvider to use a polling query in cases where the websocket is not open. The query uses after to retrieve slices of logs. Depends on https://dagster.phacility.com/D8220. Force query branch in code. Launch a run. Verify that polling occurs correctly, and that the Gantt and logs table update correctly as well. Verify that the polling terminates properly when the status reaches a completed state.
Diff Detail
Event TimelineComment Actions will do some manual QA here
Comment Actions This looks great to me! Only other thing that occurs to me is that we also show streaming logs when you open a step's stderr | stdout panel from the bottom half of the run details view... I wonder if we need a similar fork over there?
|