Page MenuHomeElementl
Differential D8220

[dagster-graphql] PipelineRun.events
ClosedPublic
Actions

Authored by alangenfeld on Jun 3 2021, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 10, 9:10 PM
Unknown Object (File)
Feb 15 2023, 11:10 AM
Unknown Object (File)
Feb 14 2023, 10:08 AM
Unknown Object (File)
Feb 11 2023, 11:51 AM
Unknown Object (File)
Feb 11 2023, 2:41 AM
Unknown Object (File)
Feb 11 2023, 2:38 AM
Unknown Object (File)
Feb 9 2023, 3:08 PM
Unknown Object (File)
Feb 8 2023, 6:20 PM
View All 81 Files
Subscribers
None

Details

Reviewers
• dgibson
• catherinewu
• max
• jordansanders
Commits
R1:75fff768c178: [dagster-graphql] PipelineRun.events
Summary

support fetching events by query instead of just subscription

Test Plan

added tests

Diff Detail

Repository
R1 dagster
Branch
events
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

alangenfeld created this revision.Jun 3 2021, 3:43 PM
Harbormaster completed remote builds in B31594: Diff 38892.Jun 3 2021, 4:07 PM
alangenfeld requested review of this revision.Jun 3 2021, 4:07 PM
alangenfeld updated this revision to Diff 38899.Jun 3 2021, 4:22 PM

add basic test

alangenfeld updated this revision to Diff 38901.Jun 3 2021, 4:32 PM

pagination test

alangenfeld edited the test plan for this revision. (Show Details)Jun 3 2021, 4:36 PM
alangenfeld added reviewers: • dgibson, • catherinewu, • max.
Harbormaster completed remote builds in B31598: Diff 38899.Jun 3 2021, 4:45 PM
Harbormaster completed remote builds in B31600: Diff 38901.Jun 3 2021, 4:55 PM
alangenfeld added a reviewer: • jordansanders.Jun 3 2021, 5:13 PM
• dish mentioned this in D8224: [dagit] Add a polling query for Run logs.Jun 3 2021, 5:23 PM
• dish added a child revision: D8224: [dagit] Add a polling query for Run logs.Jun 3 2021, 5:23 PM
• max accepted this revision.Jun 3 2021, 6:07 PM
• max added inline comments.
js_modules/dagit/packages/core/src/graphql/schema.graphql
272

should we mark this file as generated

This revision is now accepted and ready to land.Jun 3 2021, 6:07 PM
alangenfeld added inline comments.Jun 3 2021, 6:56 PM
js_modules/dagit/packages/core/src/graphql/schema.graphql
272

i find it useful for reviewing schema changes (when the file doesn't get violently thrashed like this)

Closed by commit R1:75fff768c178: [dagster-graphql] PipelineRun.events (authored by alangenfeld). · Explain WhyJun 3 2021, 6:57 PM
This revision was automatically updated to reflect the committed changes.
alangenfeld added a commit: R1:75fff768c178: [dagster-graphql] PipelineRun.events.
• dish mentioned this in R1:f2a958f55a7f: [dagit] Add a polling query for Run logs.Jun 3 2021, 7:43 PM

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
graphql/
1143 lines
python_modules/
dagster-graphql/
dagster_graphql/
client/
54 lines
schema/
pipelines/
17 lines
dagster_graphql_tests/
graphql/
153 lines

Diff 38901

View Options

js_modules/dagit/packages/core/src/graphql/possibleTypes.generated.json

Loading...
View Options

js_modules/dagit/packages/core/src/graphql/schema.graphql

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/client/query.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execute_pipeline.py

Loading...