Page MenuHomeElementl

[dagit] Do not disable Launch buttons
ClosedPublic

Authored by dish on Jun 3 2021, 3:21 PM.

Details

Summary

Instead of disabling launch-run buttons when websockets aren't connected, enable the button and show an error when the run cannot be launched -- including for situations where the webserver is down.

This allows users to launch runs even if they are unable to use websockets.

Test Plan

With webserver running, verify that I can launch runs from playground and via old runs.

Kill webserver with playground page open. Attempt to launch run, verify that the error dialog appears.

Repeat above on Run page. Verify that error appears.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Jun 3 2021, 3:31 PM
dgibson added inline comments.
js_modules/dagit/packages/core/src/execute/showLaunchError.tsx
11

bit specific, but the fallback is reasonable at least

This revision is now accepted and ready to land.Jun 3 2021, 4:20 PM
This revision was automatically updated to reflect the committed changes.