Differential D8212

Fix wrapping of SQL details displayed in the solid definition tab #4181
ClosedPublic
Actions

Authored by • bengotow on Jun 3 2021, 6:11 AM.

Details

Reviewers

• dish

Commits

R1:9c9050a2c222: Fix wrapping of SQL details displayed in the solid definition tab #4181

Summary

Fixes a prop that was not applied correctly to resolve https://github.com/dagster-io/dagster/issues/4181

Before:

Screen Shot 2021-06-03 at 12.54.13 AM.png (1×1 px, 503 KB)

After:

Screen Shot 2021-06-03 at 12.57.03 AM.png (1×1 px, 441 KB)

Test Plan

View SQL on a solid

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• bengotow created this revision.Jun 3 2021, 6:11 AM

• bengotow edited the summary of this revision. (Show Details)Jun 3 2021, 6:12 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 3 2021, 6:56 AM

Harbormaster failed remote builds in B31580: Diff 38872!

Update snapshots

Harbormaster completed remote builds in B31584: Diff 38876.Jun 3 2021, 2:11 PM

• bengotow requested review of this revision.Jun 3 2021, 2:11 PM

• dish accepted this revision.Jun 3 2021, 7:52 PM

This revision is now accepted and ready to land.Jun 3 2021, 7:52 PM

Closed by commit R1:9c9050a2c222: Fix wrapping of SQL details displayed in the solid definition tab #4181 (authored by • bengotow). · Explain WhyJun 3 2021, 10:02 PM

This revision was automatically updated to reflect the committed changes.

• bengotow added a commit: R1:9c9050a2c222: Fix wrapping of SQL details displayed in the solid definition tab #4181.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

plugins/

sql.tsx

2 lines

ui/

HighlightedCodeBlock.tsx

6 lines

__snapshots__/

HighlightedCodeBlock.test.tsx.snap

Diff 38976

View Options

js_modules/dagit/packages/core/src/plugins/sql.tsx

View Options

js_modules/dagit/packages/core/src/ui/HighlightedCodeBlock.tsx

View Options

js_modules/dagit/packages/core/src/ui/snapshots/HighlightedCodeBlock.test.tsx.snap

Fix wrapping of SQL details displayed in the solid definition tab #4181ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38976

js_modules/dagit/packages/core/src/plugins/sql.tsx

js_modules/dagit/packages/core/src/ui/HighlightedCodeBlock.tsx

js_modules/dagit/packages/core/src/ui/__snapshots__/HighlightedCodeBlock.test.tsx.snap

Fix wrapping of SQL details displayed in the solid definition tab #4181
ClosedPublic
Actions

Revision Contents
Changeset List

js_modules/dagit/packages/core/src/ui/snapshots/HighlightedCodeBlock.test.tsx.snap