Page MenuHomeElementl

[dagit] Clean up GraphQL mocks
ClosedPublic

Authored by dish on Jun 2 2021, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 21, 2:41 PM
Unknown Object (File)
Sun, Jan 15, 6:18 PM
Unknown Object (File)
Sat, Jan 7, 4:48 PM
Unknown Object (File)
Dec 17 2022, 3:22 PM
Unknown Object (File)
Dec 5 2022, 1:54 AM
Unknown Object (File)
Nov 24 2022, 8:14 AM
Unknown Object (File)
Nov 18 2022, 2:14 AM
Unknown Object (File)
Nov 17 2022, 11:35 PM
Subscribers
None

Details

Summary

Add all FooOrError GraphQL unions to defaultMocks, defaulting to the non-error type. This allows cleaning up a bunch of mock overrides in tests.

There was a test flake on App.test in an earlier master build, I'm hoping this will help.

Test Plan

yarn jest

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Also clean up how default mocks are being merged, since overriding spreads could be unwise.

This revision is now accepted and ready to land.Jun 3 2021, 2:15 PM
This revision was automatically updated to reflect the committed changes.