Page MenuHomeElementl
Differential D8205

[dagit] Clean up GraphQL mocks
ClosedPublic
Actions

Authored by • dish on Jun 2 2021, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 21, 2:41 PM
Unknown Object (File)
Sun, Jan 15, 6:18 PM
Unknown Object (File)
Sat, Jan 7, 4:48 PM
Unknown Object (File)
Dec 17 2022, 3:22 PM
Unknown Object (File)
Dec 5 2022, 1:54 AM
Unknown Object (File)
Nov 24 2022, 8:14 AM
Unknown Object (File)
Nov 18 2022, 2:14 AM
Unknown Object (File)
Nov 17 2022, 11:35 PM
View All 72 Files
Subscribers
None

Details

Reviewers
• bengotow
• dgibson
Commits
R1:6b5169812b3d: [dagit] Clean up GraphQL mocks
Summary

Add all FooOrError GraphQL unions to defaultMocks, defaulting to the non-error type. This allows cleaning up a bunch of mock overrides in tests.

There was a test flake on App.test in an earlier master build, I'm hoping this will help.

Test Plan

yarn jest

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.Jun 2 2021, 7:27 PM
Harbormaster completed remote builds in B31544: Diff 38828.Jun 2 2021, 7:37 PM
• dish requested review of this revision.Jun 2 2021, 7:37 PM
• dish updated this revision to Diff 38836.Jun 2 2021, 8:00 PM

Also clean up how default mocks are being merged, since overriding spreads could be unwise.

Harbormaster completed remote builds in B31550: Diff 38836.Jun 2 2021, 8:09 PM
• bengotow accepted this revision.Jun 3 2021, 2:15 PM
This revision is now accepted and ready to land.Jun 3 2021, 2:15 PM
Closed by commit R1:6b5169812b3d: [dagit] Clean up GraphQL mocks (authored by • dish). · Explain WhyJun 3 2021, 2:18 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:6b5169812b3d: [dagit] Clean up GraphQL mocks.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
app/
23 lines
assets/
6 lines
nav/
29 lines
19 lines
44 lines
20 lines
testing/
16 lines
136 lines

Diff 38881

View Options

js_modules/dagit/packages/core/src/app/App.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/assets/AssetDetails.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/nav/InstanceWarningIcon.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/nav/LeftNav.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/nav/LeftNavRepositorySection.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/nav/RepositoryPicker.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/testing/ApolloTestProvider.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/testing/defaultMocks.ts

Loading...