Page MenuHomeElementl

[dagit] Fix runs pagination

Authored by dish on Jun 2 2021, 3:03 PM.
Referenced Files
Unknown Object (File)
Wed, May 10, 6:41 PM
Unknown Object (File)
Apr 29 2023, 12:14 AM
Unknown Object (File)
Apr 12 2023, 5:45 AM
Unknown Object (File)
Apr 9 2023, 5:55 PM
Unknown Object (File)
Mar 29 2023, 6:16 AM
Unknown Object (File)
Mar 24 2023, 2:22 PM
Unknown Object (File)
Mar 14 2023, 12:35 PM
Unknown Object (File)
Feb 23 2023, 8:25 PM



Resolves #4228

A couple fixes related to runs pagination.

  • Paginating backward on a pipeline's Runs tab does not work. This is because the route is defined with component, which remounts every time it is rendered. It should be a render prop instead.
  • Our slicing is off by one in all cases. We retrieve limit + 1 results to determine whether we need "next" pagination, but then we're setting the next cursor based on the sliced-off item. We therefore never show the sliced-off item at all, since it doesn't appear in the next page. Fix this by using the limit item as our cursor.
Test Plan

Verify that the Pipeline Runs tab pages forward and backward successfully.

Verify that all retrieved Run items are displayed in the list, on Pipeline Runs and on /runs.

Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable