Page MenuHomeElementl

K8s executor docs
ClosedPublic

Authored by johann on Jun 2 2021, 2:54 PM.

Details

Test Plan

make dev

Integration
(bc adding experimental annotation)

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johann requested review of this revision.Jun 2 2021, 3:39 PM
docs/content/deployment/guides/kubernetes/deploying-with-helm.mdx
143

not sure if this is the right place for this discussion

not a k8s expert, but the content and the structure look great to me! will let others sign off on the code example piece

docs/content/deployment/guides/kubernetes/deploying-with-helm.mdx
142

would be good to link to PyObject when mentioning "in-process", "multiprocess", "celery_k8s_job_executor", and "k8s_job_executor".

143

i think it's good to mention it here.

my take is it's fine to duplicate certain content. in this case, users would usually just look at this page itself and hope to learn all they need to know about deploying to k8s, so i think having this discussion here is good for that purpose.

dgibson added inline comments.
docs/content/deployment/guides/kubernetes/deploying-with-helm.mdx
142

some optional nits/suggestions

s/sets/determines?

link to the api docs for the different executors maybe?

you can probably drop 'new' before k8s_job_executor

drop the 'also' in Generally, increasing isolation also incurs

explain how (via run config) when you say they can be configured per run?

python_modules/libraries/dagster-k8s/dagster_k8s/executor.py
44

if its' experimental should it have the experimental marker

drop 'currently'?

77

Do we need the DAGSTER_CURRENT_IMAGE branch? I think it's better to pull that from the pipeline origin like the CeleryDockerExecutor does

This revision is now accepted and ready to land.Jun 4 2021, 3:15 PM
python_modules/libraries/dagster-k8s/dagster_k8s/executor.py
77

ack, will do in a non docs diff (just moved this to the top of the file without changes since it has the doc string now)

This revision was automatically updated to reflect the committed changes.