Page MenuHomeElementl

Make pending node invocations pulled from solids invokable
ClosedPublic

Authored by cdecarolis on Jun 1 2021, 5:35 PM.
Tags
None
Referenced Files
F2289756: D8184.id.diff
Thu, Jun 30, 12:46 PM
Unknown Object (File)
Wed, Jun 29, 8:55 AM
Unknown Object (File)
Fri, Jun 24, 7:29 AM
Unknown Object (File)
Thu, Jun 23, 9:07 PM
Unknown Object (File)
Thu, Jun 23, 4:35 PM
Unknown Object (File)
Thu, Jun 23, 3:40 AM
Unknown Object (File)
Tue, Jun 21, 8:59 AM
Unknown Object (File)
Mon, Jun 20, 9:14 AM
Subscribers
None

Details

Summary

This diff makes pending node invocations (that are pulled from solids) invokable.

Issue tracking: https://github.com/dagster-io/dagster/issues/4218

Test Plan

Unit tests

Diff Detail

Repository
R1 dagster
Branch
pendingnodeinvocation
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/composition.py
272–273

add comment so this sticks out

also this probably isn't quite right see recommended test case below

470–478

*

python_modules/dagster/dagster_tests/core_tests/test_solid_invocation.py
550–555

add a tag test case that actually asserts the set tags are on the context

This revision now requires changes to proceed.Jun 1 2021, 8:34 PM

Save along attributes from invocations

Explain aliased error message tests

cdecarolis requested review of this revision.

bump

alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/composition.py
267–295

what happens if you try to directly execute a composite solid? I know we used to have assert is in composition errors

python_modules/dagster/dagster/core/execution/context/invocation.py
207–224

keyword args please

This revision is now accepted and ready to land.Jun 3 2021, 8:45 PM

Re-add assert_in_composition stuff