Paths

Table of Contentst

Differential D8184

Make pending node invocations pulled from solids invokable
ClosedPublic
Actions

Authored by • cdecarolis on Jun 1 2021, 5:35 PM.

Tags

None

Referenced Files

	F2292486: D8184.diff
	Fri, Jul 1, 10:58 AM

	F2289756: D8184.id.diff
	Thu, Jun 30, 12:46 PM

	Unknown Object (File)
	Wed, Jun 29, 8:55 AM

	Unknown Object (File)
	Fri, Jun 24, 7:29 AM

	Unknown Object (File)
	Thu, Jun 23, 9:07 PM

	Unknown Object (File)
	Thu, Jun 23, 4:35 PM

	Unknown Object (File)
	Thu, Jun 23, 3:40 AM

	Unknown Object (File)
	Tue, Jun 21, 8:59 AM

View All 27 Files

Subscribers

None

Details

Reviewers

• sandyryza
alangenfeld

Commits

R1:ebe034d1ed28: Make pending node invocations pulled from solids invokable

Summary

This diff makes pending node invocations (that are pulled from solids) invokable.

Issue tracking: https://github.com/dagster-io/dagster/issues/4218

Test Plan

Unit tests

Diff Detail

Repository

Branch

pendingnodeinvocation

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• cdecarolis created this revision.Jun 1 2021, 5:35 PM

Harbormaster completed remote builds in B31469: Diff 38727.Jun 1 2021, 5:59 PM

• cdecarolis requested review of this revision.Jun 1 2021, 5:59 PM

• cdecarolis edited the summary of this revision. (Show Details)Jun 1 2021, 6:26 PM

alangenfeld requested changes to this revision.Jun 1 2021, 8:34 PM

alangenfeld added inline comments.

python_modules/dagster/dagster/core/definitions/composition.py
256–257	add comment so this sticks out also this probably isn't quite right see recommended test case below
432–440	*
python_modules/dagster/dagster_tests/core_tests/test_solid_invocation.py
491–496	add a `tag` test case that actually asserts the set tags are on the context

This revision now requires changes to proceed.Jun 1 2021, 8:34 PM

Save along attributes from invocations

Explain aliased error message tests

Update comment block

Harbormaster completed remote builds in B31531: Diff 38807.Jun 2 2021, 6:17 PM

Harbormaster completed remote builds in B31532: Diff 38808.Jun 2 2021, 6:21 PM

Harbormaster completed remote builds in B31534: Diff 38811.Jun 2 2021, 6:41 PM

bump

alangenfeld accepted this revision.Jun 3 2021, 8:45 PM

alangenfeld added inline comments.

python_modules/dagster/dagster/core/definitions/composition.py
254–282	what happens if you try to directly execute a composite solid? I know we used to have assert is in composition errors
python_modules/dagster/dagster/core/execution/context/invocation.py
207–223 ↗	(On Diff #38811)	keyword args please

This revision is now accepted and ready to land.Jun 3 2021, 8:45 PM

Re-add assert_in_composition stuff

Up

coolbeans

Harbormaster completed remote builds in B31655: Diff 38972.Jun 3 2021, 10:12 PM

Harbormaster completed remote builds in B31656: Diff 38973.Jun 3 2021, 10:16 PM

Closed by commit R1:ebe034d1ed28: Make pending node invocations pulled from solids invokable (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyJun 3 2021, 10:38 PM

This revision was automatically updated to reflect the committed changes.

Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:ebe034d1ed28: Make pending node invocations pulled from solids invokable.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster/

core/

definitions/

5 lines

dagster_tests/

core_tests/

test_solid_invocation.py

8 lines

Diff 38727

python_modules/dagster/dagster/core/definitions/composition.py

Loading...

python_modules/dagster/dagster_tests/core_tests/test_solid_invocation.py

Loading...