Page MenuHomeElementl

Make pending node invocations pulled from solids invokable
ClosedPublic

Authored by cdecarolis on Tue, Jun 1, 5:35 PM.

Details

Summary

This diff makes pending node invocations (that are pulled from solids) invokable.

Issue tracking: https://github.com/dagster-io/dagster/issues/4218

Test Plan

Unit tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/composition.py
272–273

add comment so this sticks out

also this probably isn't quite right see recommended test case below

470–478

*

python_modules/dagster/dagster_tests/core_tests/test_solid_invocation.py
550–555

add a tag test case that actually asserts the set tags are on the context

This revision now requires changes to proceed.Tue, Jun 1, 8:34 PM

Save along attributes from invocations

Explain aliased error message tests

cdecarolis requested review of this revision.

bump

alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/composition.py
267–295

what happens if you try to directly execute a composite solid? I know we used to have assert is in composition errors

python_modules/dagster/dagster/core/execution/context/invocation.py
207–224

keyword args please

This revision is now accepted and ready to land.Thu, Jun 3, 8:45 PM

Re-add assert_in_composition stuff