the dagster core tests are hitting 18m need to figure out which ones are worst
• dgibson • jordansanders • max
- R1:0d50e0365cf3: show 10 slowest core tests
This is great! One of the things on my backlog that I want to get to once I find time is to save off metadata about our builds and make them in Mode or somewhere so we can query over time on which tests are slowest and which are flakiest. That way we can effectively prioritize keeping builds fast and green. But until something like that, I think this is a really good first step.
We should also pass in -n since we're using pytest-xdist https://github.com/pytest-dev/pytest-xdist#speed-up-test-runs-by-sending-tests-to-multiple-cpus? looks like we're only using this in dagit tests right now
39.04s call dagster_tests/core_tests/dynamic_tests/test_dynamic_execution.py::test_partial_reexecute[run_config1] 34.48s call dagster_tests/core_tests/dynamic_tests/test_dynamic_execution.py::test_fan_out_in_out_in[run_config1] 32.89s call dagster_tests/core_tests/host_representation_tests/test_grpc_server_registry.py::test_process_server_registry 26.33s call dagster_tests/core_tests/dynamic_tests/test_dynamic_execution.py::test_map_reexecute_after_fail[run_config1] 22.87s call dagster_tests/core_tests/dynamic_tests/test_dynamic_execution.py::test_map[run_config1] 14.51s call dagster_tests/core_tests/launcher_tests/test_default_run_launcher.py::test_engine_events[run_config1-get_external_pipeline_from_managed_grpc_python_env_repository] 13.97s call dagster_tests/core_tests/launcher_tests/test_default_run_launcher.py::test_engine_events[run_config1-get_external_pipeline_from_grpc_server_repository] 13.27s call dagster_tests/core_tests/engine_tests/test_priorities.py::test_priorities_mp 12.40s call dagster_tests/core_tests/execution_plan_tests/test_external_step.py::test_multiproc_launcher_requests_retry 11.78s call dagster_tests/core_tests/execution_tests/test_retries.py::test_step_retry_limit[environment1]