remove gh issue for cursor_res
ClosedPublic
Actions

Authored by alangenfeld on Jun 1 2021, 4:48 PM.

Details

Reviewers

Commits

R1:3cfc9c14dd76: remove gh issue for cursor_res

Summary

looking at https://github.com/dagster-io/dagster/issues/3858 and https://dagster.phacility.com/D6943 - not sure what exactly was meant to be done so putting up this diff

Test Plan

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alangenfeld created this revision.Jun 1 2021, 4:48 PM

Harbormaster completed remote builds in B31461: Diff 38718.Jun 1 2021, 5:11 PM

alangenfeld requested review of this revision.Jun 1 2021, 5:11 PM

This issue was there to track a mypy problem because we had a pin in SqlAlchemy for <1.4 (I think related to this diff). I'll add in the type annotation in a separate diff - this LGTM. thanks for catching this Alex.

• sidkmenon accepted this revision.Jun 1 2021, 5:29 PM

This revision is now accepted and ready to land.Jun 1 2021, 5:29 PM

Closed by commit R1:3cfc9c14dd76: remove gh issue for cursor_res (authored by alangenfeld). · Explain WhyJun 1 2021, 6:59 PM

This revision was automatically updated to reflect the committed changes.

alangenfeld added a commit: R1:3cfc9c14dd76: remove gh issue for cursor_res.

alangenfeld mentioned this in D8174: Attempt an unpin of sqlalchemy in dagster-airflow.Jun 2 2021, 7:28 PM

Revision Contents
Changeset List

Path

Size

python_modules/

libraries/

dagster-postgres/

dagster_postgres/

event_log/

event_log.py

1 line

Diff 38738

View Options

python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py

remove gh issue for cursor_resClosedPublicActions