Page MenuHomeElementl
Differential D8174

Attempt an unpin of sqlalchemy in dagster-airflow
AbandonedPublic
Actions

Authored by • dgibson on Jun 1 2021, 2:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 16, 5:32 AM
Unknown Object (File)
Fri, Mar 10, 9:10 PM
Unknown Object (File)
Fri, Mar 3, 4:31 PM
Unknown Object (File)
Sat, Feb 25, 7:07 PM
Unknown Object (File)
Feb 10 2023, 2:42 AM
Unknown Object (File)
Feb 9 2023, 11:17 PM
Unknown Object (File)
Feb 9 2023, 9:09 PM
Unknown Object (File)
Feb 7 2023, 1:43 PM
View All 86 Files
Subscribers
None

Details

Reviewers
• sashank
• max
alangenfeld
Summary

If successful, resolves https://github.com/dagster-io/dagster/issues/3858

My recollection was that BK tests were failing before we pinned?

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
unpin (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• dgibson created this revision.Jun 1 2021, 2:56 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 1 2021, 3:18 PM
Harbormaster failed remote builds in B31443: Diff 38696!
• dgibson updated this revision to Diff 38703.Jun 1 2021, 3:41 PM

more pins

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 1 2021, 4:02 PM
Harbormaster failed remote builds in B31449: Diff 38703!
• dgibson updated this revision to Diff 38709.Jun 1 2021, 4:03 PM

moar pins

Harbormaster completed remote builds in B31454: Diff 38709.Jun 1 2021, 4:25 PM
• dgibson requested review of this revision.Jun 1 2021, 4:25 PM
• dgibson added inline comments.Jun 1 2021, 4:28 PM
python_modules/libraries/dagster-airflow/setup.py
42–43

this pin seems less bad to me since it's in dagit as well

alangenfeld added a comment.Jun 1 2021, 4:37 PM

https://dagster.phacility.com/D8138

alangenfeld added a comment.Jun 1 2021, 5:00 PM

^ my diff moves the pin to the test extras since we only pin our airflow version in test, I think this solves the user aspect of the problem

you'll at least want to move these other pins in to test if we even want to bother

alangenfeld requested changes to this revision.Jun 1 2021, 8:38 PM

to your queue

This revision now requires changes to proceed.Jun 1 2021, 8:38 PM
• dgibson abandoned this revision.Jun 2 2021, 3:50 AM
• max added a comment.Jun 2 2021, 7:25 PM

what about sid's comment on https://github.com/dagster-io/dagster/issues/3858?

alangenfeld added a comment.EditedJun 2 2021, 7:28 PM

what about sid's comment on https://github.com/dagster-io/dagster/issues/3858?

https://dagster.phacility.com/D8181 was the action i took to follow up

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
2 lines
libraries/
dagster-airflow/
7 lines
dagster-snowflake/
2 lines

Diff 38703

View Options

python_modules/dagster/setup.py

Loading...
View Options

python_modules/libraries/dagster-airflow/setup.py

Loading...
View Options

python_modules/libraries/dagster-snowflake/setup.py

Loading...