Page MenuHomeElementl

Attempt an unpin of sqlalchemy in dagster-airflow
AbandonedPublic

Authored by dgibson on Jun 1 2021, 2:56 PM.

Details

Summary

If successful, resolves https://github.com/dagster-io/dagster/issues/3858

My recollection was that BK tests were failing before we pinned?

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
unpin (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 1 2021, 3:18 PM
Harbormaster failed remote builds in B31443: Diff 38696!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 1 2021, 4:02 PM
Harbormaster failed remote builds in B31449: Diff 38703!
python_modules/libraries/dagster-airflow/setup.py
42–43

this pin seems less bad to me since it's in dagit as well

^ my diff moves the pin to the test extras since we only pin our airflow version in test, I think this solves the user aspect of the problem

you'll at least want to move these other pins in to test if we even want to bother

to your queue

This revision now requires changes to proceed.Jun 1 2021, 8:38 PM