Page MenuHomeElementl

allow backfill actions to cancel runs
AbandonedPublic

Authored by prha on May 28 2021, 7:54 PM.

Details

Summary

We had the wrong termination logic, which filtered out queued runs

This diff changes the backfill termination UI logic to match the Partition UI termination logic

GH issue: https://github.com/dagster-io/dagster/issues/4208

Test Plan

bk, configured run coordinator to cap the concurrent runs, killed the daemon, made sure that queued runs could be canceled.

Diff Detail

Repository
R1 dagster
Branch
prha/backfill
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

prha requested review of this revision.May 28 2021, 8:05 PM
rexledesma added inline comments.
js_modules/dagit/packages/core/src/instance/InstanceBackfills.tsx
288
This revision now requires changes to proceed.May 29 2021, 3:03 AM

The better fix would be to fix the resolver for canTerminate, which involves changing the logic in some run launchers