Paths

Table of Contentst

allow backfill actions to cancel runs
AbandonedPublic
Actions

Authored by • prha on May 28 2021, 7:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 11, 1:56 PM

	Unknown Object (File)
	Thu, May 4, 12:08 AM

	Unknown Object (File)
	Apr 22 2023, 8:20 AM

	Unknown Object (File)
	Apr 16 2023, 12:32 PM

	Unknown Object (File)
	Apr 10 2023, 11:26 AM

	Unknown Object (File)
	Mar 27 2023, 7:34 PM

	Unknown Object (File)
	Mar 18 2023, 11:37 PM

	Unknown Object (File)
	Mar 10 2023, 7:06 PM

View All 65 Files

Subscribers

None

Details

Reviewers

• sandyryza
• yuhan
• rexledesma

Summary

We had the wrong termination logic, which filtered out queued runs

This diff changes the backfill termination UI logic to match the Partition UI termination logic

GH issue: https://github.com/dagster-io/dagster/issues/4208

Test Plan

bk, configured run coordinator to cap the concurrent runs, killed the daemon, made sure that queued runs could be canceled.

Diff Detail

Repository

R1 dagster

Branch

prha/backfill

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• prha created this revision.May 28 2021, 7:54 PM

Harbormaster completed remote builds in B31415: Diff 38663.May 28 2021, 8:05 PM

• prha requested review of this revision.May 28 2021, 8:05 PM

• rexledesma requested changes to this revision.May 29 2021, 3:03 AM

• rexledesma added inline comments.

js_modules/dagit/packages/core/src/instance/InstanceBackfills.tsx
288

This revision now requires changes to proceed.May 29 2021, 3:03 AM

The better fix would be to fix the resolver for canTerminate, which involves changing the logic in some run launchers

• prha abandoned this revision.Jul 27 2021, 3:18 PM

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

instance/

BackfillTerminationDialog.tsx

4 lines

InstanceBackfills.tsx

2 lines

Diff 38663

View Options

js_modules/dagit/packages/core/src/instance/BackfillTerminationDialog.tsx