[memoization] ensure that versions are properly passed from configured
ClosedPublic
Actions

Authored by • cdecarolis on May 28 2021, 7:31 PM.

Details

Reviewers

Commits

R1:8bda076ba55b: [memoization] ensure that versions are properly passed from configured

Summary

After a lengthy back and forth with a user, we found a bug where versions were not being passed through configured. This fixes, and places under test.

Test Plan

unit

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Harbormaster failed remote builds in B31412: Diff 38658!May 28 2021, 7:52 PM

Harbormaster returned this revision to the author for changes because remote builds failed.May 28 2021, 7:54 PM

Harbormaster failed remote builds in B31414: Diff 38660!

Harbormaster completed remote builds in B31417: Diff 38665.May 28 2021, 8:55 PM

• cdecarolis requested review of this revision.May 28 2021, 8:55 PM

• sandyryza accepted this revision.May 29 2021, 12:17 AM

This revision is now accepted and ready to land.May 29 2021, 12:17 AM

Closed by commit R1:8bda076ba55b: [memoization] ensure that versions are properly passed from configured (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyJun 1 2021, 2:42 PM

This revision was automatically updated to reflect the committed changes.

Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:8bda076ba55b: [memoization] ensure that versions are properly passed from configured.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

definitions/

resource.py

1 line

dagster_tests/

core_tests/

test_resolve_versions.py

14 lines

Diff 38694

View Options

python_modules/dagster/dagster/core/definitions/resource.py