Page MenuHomeElementl

Reorg implementation of config eval on solid invocation
ClosedPublic

Authored by cdecarolis on Thu, May 27, 10:29 PM.

Details

Summary

This diff reorgs the implementation of config evaluation on solid invocation. Essentially, the Shape config type cannot accept a None value ever, and the underlying config type to the solid definition may not permit a dict. The solution is to always wrap in a shape, permitting us to place a dict as default arg
I'm not sure if this is actuall an improvement, but it's at least more clear about what's going on.

Test Plan

unit tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, May 27, 10:50 PM
Harbormaster failed remote builds in B31380: Diff 38619!

kingler

python_modules/dagster/dagster/core/execution/context/invocation.py
225–231

comment block explaining outer layer

237

is {} right default here?

This revision is now accepted and ready to land.Tue, Jun 1, 4:08 PM
python_modules/dagster/dagster/core/execution/context/invocation.py
237

You're right - None is fine I think

also at [1]

242–243

[1]