Page MenuHomeElementl

update virtualenv before running tox
ClosedPublic

Authored by alangenfeld on May 27 2021, 4:12 PM.

Details

Summary
  • update virtualenv to have tox use latest pip
  • drop our`==version` pins when its dev to avoid the dependency resolver bug
  • move airflow pins that are specific to the version we test in to the test section
Test Plan

bk
make install_dev_python_modules_verbose

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 27 2021, 4:30 PM
Harbormaster failed remote builds in B31318: Diff 38546!
alangenfeld added inline comments.
.buildkite/dagster-buildkite/dagster_buildkite/module_build_spec.py
105

we can also update all the tox files to set the requires entry in tox to have it run this update or pin to a specific version

the last thing i am stuck on is the dbt_example is getting stuck in backtracking hell

alangenfeld edited the summary of this revision. (Show Details)

try a constraints file

more constraints? this is really annoying

examples/dbt_example/setup.py
17

the backtracking hell was because grpcio tools in dbt-bigquery 0.18.2 conflicts with dagsters reqs

not sure why this is not surfaced more effectively before pip spirals out of control in to backtracking nightmare land

jordansanders added inline comments.
python_modules/dagit/setup.py
23

Love it 😍

I wonder if this would allow us to revert https://github.com/dagster-io/dagster/commit/99ce9c8ba0bbebdbad9e201e760a28fa52bc73ca (consequently simplifying and speeding up our dev installs and release pipeline)

This revision is now accepted and ready to land.May 27 2021, 9:28 PM
This revision was automatically updated to reflect the committed changes.