Page MenuHomeElementl

[retry] backoff and jitter
ClosedPublic

Authored by alangenfeld on Wed, May 26, 6:09 PM.

Details

Summary

Add declarative delay modifiers backoff and jitter as enums. Put a few entries to start but we can add more if requested.

Test Plan

added tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this looks pretty good!

supercorn

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_retries.py
354–367

pretty good, though it's just testing the boundaries and not the distribution.

369

I think yes, this should error?

This revision is now accepted and ready to land.Wed, May 26, 8:19 PM
python_modules/dagster/dagster_tests/core_tests/execution_tests/test_retries.py
354–367

do you have a recommended approach to testing distro?

rebase, error on jitter/backoff w/o delaty

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_retries.py
354–367

Well, it's not 100%, but with a large enough N, you could calculate the mean / stddev / var?

Lines 324-351 are what convince me that this is sufficient, fwiw.

This revision was automatically updated to reflect the committed changes.