Page MenuHomeElementl

get_execution_data -> evaluate_tick
ClosedPublic

Authored by cdecarolis on Wed, May 26, 2:39 PM.

Details

Summary

title. We're likely going ot make get_execution_data a public API via sensor and schedule testing, and the name is obtuse. This diff changes the name to be something that matches functionality in Dagit.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have a somewhat averse reaction to do_X function names.

Are you taking suggestions for alternatives?

  • evaluate
  • evaluate_tick
  • execute_tick
  • evaluate_sensor / evaluate_schedule

Am on board with evaluate_tick @prha

cdecarolis retitled this revision from get_execution_data -> do_tick to get_execution_data -> evaluate_tick.Wed, May 26, 3:41 PM

Get rid of weird vscode artifacts

sandyryza added inline comments.
python_modules/dagster/dagster/core/definitions/schedule.py
317–326

It would be helpful to include some docstring as well if this is going to become public.

This revision is now accepted and ready to land.Wed, May 26, 3:58 PM