Page MenuHomeElementl

[dagit] Force Asset `asOf` to behave inclusively
ClosedPublic

Authored by dish on Wed, May 26, 12:28 AM.

Details

Summary

Tack a millisecond onto the before parameter when querying asset materializations, to ensure that the cutoff is inclusive.

Test Plan

View assets in Dagit, using latest asOf, previous asOf, and no asOf. Verify that the Alert is shown only when the asOf is old.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish published this revision for review.Wed, May 26, 12:33 AM

I think need this same logic in AssetMaterializations.tsx.

Could be that the value is a NaN, but the endpoint sanitizes so it might just be fine...

This revision is now accepted and ready to land.Wed, May 26, 12:37 AM

Simplify logic, do the same for AssetMaterializations table