Page MenuHomePhabricator

[log sink] move dagstermill xproc log to dagster
ClosedPublic

Authored by alangenfeld on Tue, Aug 13, 10:51 PM.

Details

Summary

for sharing

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Tue, Aug 13, 10:51 PM
max accepted this revision.Tue, Aug 13, 11:05 PM
max added inline comments.
python_modules/dagster/dagster/loggers/xproc_log_sink.py
4

adjust readme for dagstermill?

7

we do manage the subprocess directly for some cases

28

not dagstermill

This revision is now accepted and ready to land.Tue, Aug 13, 11:05 PM
This revision was automatically updated to reflect the committed changes.