Page MenuHomePhabricator

Display required_resources in dagit
ClosedPublic

Authored by prha on Aug 13 2019, 6:39 PM.

Details

Reviewers
bengotow
schrockn
Group Reviewers
Restricted Project
Commits
R1:f250ef1fda29: Display required_resources in dagit
Summary

Adds requiredResources to the SolidDefinition graphql schema
Displays a new section in the info side panel for required resources

Issue: https://github.com/dagster-io/dagster/issues/1466

Test Plan

added test case to dagster-graphql

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Aug 13 2019, 6:39 PM
prha edited the summary of this revision. (Show Details)Aug 13 2019, 6:41 PM
prha added reviewers: Restricted Project, bengotow.
prha edited the summary of this revision. (Show Details)
prha edited the summary of this revision. (Show Details)Aug 13 2019, 6:44 PM

Looks good to me! Should we include a tooltip or something in the sidepanel UI to explain what required resources are?

schrockn requested changes to this revision.Aug 13 2019, 7:37 PM
schrockn added a subscriber: schrockn.

So think we might to have this be a row-per required resource. That way we can add things like descriptions or metadata to the resource requirement.

I think at a minimum the graphql should be a struct so that is forward-compatible with having more than a string specified.

This revision now requires changes to proceed.Aug 13 2019, 7:37 PM
prha updated this revision to Diff 3692.Aug 14 2019, 4:33 PM

create required resource object type

schrockn requested changes to this revision.Aug 14 2019, 6:11 PM

I'm getting this error in a dev build with this diff patched.

Using dev build and cleared caches.

This revision now requires changes to proceed.Aug 14 2019, 6:11 PM
prha added a comment.EditedAug 14 2019, 10:26 PM

What commands are you using to run this?

For the graphql endpoint, I'm running:

[dagster-3.6.8] prha@spork:~/code/dagster (prha/required_resources)
$ dagit -p 3333 -y examples/dagster_examples/airline_demo/repository.yaml

For the local dagit (on port 3000, pointing to http://localhost:3333/graphql), I'm running:

[dagster-3.6.8] prha@spork:~/code/dagster/js_modules/dagit (prha/required_resources)
$ make dev_webapp

Also, let me know if I'm supposed to split apart diffs into dagit vs dagster-graphql parts.

schrockn accepted this revision.Aug 14 2019, 11:22 PM

this magically fixed itself. still not sure what happened.

This revision is now accepted and ready to land.Aug 14 2019, 11:22 PM
This revision was automatically updated to reflect the committed changes.