Page MenuHomeElementl

Repin alembic
ClosedPublic

Authored by max on May 25 2021, 8:05 PM.

Details

Summary

Alembic 1.6.3 broke us, and this has been fixed in 1.6.4. See https://github.com/sqlalchemy/alembic/issues/844 and https://github.com/sqlalchemy/alembic/issues/848.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
alembic-pin
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 8:28 PM
Harbormaster failed remote builds in B31179: Diff 38357!
Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 10:33 PM
Harbormaster failed remote builds in B31203: Diff 38388!
dgibson added inline comments.
python_modules/dagster/setup.py
67–68

should we leave a link to the issue or something explaining why?

This revision is now accepted and ready to land.May 25 2021, 11:34 PM
This revision was landed with ongoing or failed builds.May 25 2021, 11:53 PM
Closed by commit R1:61bc96e42037: Repin alembic (authored by max). · Explain Why
This revision was automatically updated to reflect the committed changes.