Page MenuHomeElementl
Differential D8093

Repin alembic
ClosedPublic
Actions

Authored by • max on May 25 2021, 8:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 22, 10:08 AM
Unknown Object (File)
Mon, Mar 20, 1:43 AM
Unknown Object (File)
Fri, Mar 17, 4:12 PM
Unknown Object (File)
Wed, Mar 15, 2:39 AM
Unknown Object (File)
Sat, Mar 11, 2:04 AM
Unknown Object (File)
Fri, Mar 10, 9:27 PM
Unknown Object (File)
Tue, Mar 7, 1:01 AM
Unknown Object (File)
Sun, Feb 26, 4:30 PM
View All Files
Subscribers
None

Details

Reviewers
• dgibson
alangenfeld
• prha
Commits
R1:61bc96e42037: Repin alembic
Summary

Alembic 1.6.3 broke us, and this has been fixed in 1.6.4. See https://github.com/sqlalchemy/alembic/issues/844 and https://github.com/sqlalchemy/alembic/issues/848.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
alembic-pin
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• max created this revision.May 25 2021, 8:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 8:28 PM
Harbormaster failed remote builds in B31179: Diff 38357!
• max updated this revision to Diff 38388.May 25 2021, 10:11 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 10:33 PM
Harbormaster failed remote builds in B31203: Diff 38388!
• max updated this revision to Diff 38402.May 25 2021, 11:04 PM

rebase on D8104

Harbormaster completed remote builds in B31214: Diff 38402.May 25 2021, 11:28 PM
• max requested review of this revision.May 25 2021, 11:28 PM
• dgibson accepted this revision.May 25 2021, 11:34 PM
• dgibson added inline comments.
python_modules/dagster/setup.py
67–68

should we leave a link to the issue or something explaining why?

This revision is now accepted and ready to land.May 25 2021, 11:34 PM
• max updated this revision to Diff 38419.May 25 2021, 11:52 PM

add comment

This revision was landed with ongoing or failed builds.May 25 2021, 11:53 PM
Closed by commit R1:61bc96e42037: Repin alembic (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:61bc96e42037: Repin alembic.
Harbormaster failed remote builds in B31227: Diff 38419!May 26 2021, 12:13 AM

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
3 lines

Diff 38419

View Options

python_modules/dagster/setup.py

Loading...