Page MenuHomeElementl

change asset events parameters from before_timestamp to asof_timestamp, which is inclusive
ClosedPublic

Authored by prha on May 25 2021, 6:38 PM.

Details

Summary

We want the events returned to be inclusive of the timestamp, so instead of doing some +1 shenanigans, changed to be <= and renamed to asof_timestamp.

Because this diff also adds the method to the instance docs, we should take an extra beat and see if this is ultimately the API we want.

This supports the asOf parameter that shows historical snapshots of asset pages.

Adding alex and yuhan because there are some parallels to the run API changes we're making.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 7:21 PM
Harbormaster failed remote builds in B31159: Diff 38327!
prha requested review of this revision.May 25 2021, 9:03 PM
prha added reviewers: alangenfeld, yuhan, dish.

I think technically this is a breaking change, but I think it's okay because it's not publicly documented anywhere and only used internally since 0.11.8

im currently not making changes to the event storage so no overlaps.
on a side note, i think i've been updating some storage related methods on the instance without calling them breaking changes 😅

This revision is now accepted and ready to land.May 25 2021, 10:15 PM