Page MenuHomePhabricator

Actually preserve the original config dict
ClosedPublic

Authored by max on Aug 13 2019, 6:29 PM.

Details

Diff Detail

Repository
R1 dagster
Branch
composite-execution-plan
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Aug 13 2019, 6:29 PM
natekupp accepted this revision.Aug 13 2019, 7:35 PM
natekupp added a subscriber: natekupp.
natekupp added inline comments.
python_modules/dagster/dagster/core/system_config/objects.py
85

add check.dict_param() for original_config_dict?

This revision is now accepted and ready to land.Aug 13 2019, 7:35 PM
schrockn accepted this revision.Aug 13 2019, 7:35 PM
schrockn added a subscriber: schrockn.

nice very surgical

max added inline comments.Aug 13 2019, 11:05 PM
python_modules/dagster/dagster/core/system_config/objects.py
85

yup