Page MenuHomePhabricator

Actually preserve the original config dict
ClosedPublic

Authored by max on Aug 13 2019, 6:29 PM.

Details

Reviewers
nate
schrockn
Group Reviewers
Restricted Project
Commits
R1:e51ac849fc83: Actually preserve the original config dict
Summary
Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Aug 13 2019, 6:29 PM
nate accepted this revision.Aug 13 2019, 7:35 PM
nate added a subscriber: nate.
nate added inline comments.
python_modules/dagster/dagster/core/system_config/objects.py
87

add check.dict_param() for original_config_dict?

This revision is now accepted and ready to land.Aug 13 2019, 7:35 PM
schrockn accepted this revision.Aug 13 2019, 7:35 PM
schrockn added a subscriber: schrockn.

nice very surgical

max added inline comments.Aug 13 2019, 11:05 PM
python_modules/dagster/dagster/core/system_config/objects.py
87

yup