Page MenuHomeElementl
Differential D8086

Use compat layer for typing introspection
ClosedPublic
Actions

Authored by • max on May 25 2021, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 26, 12:32 PM
Unknown Object (File)
Thu, May 25, 10:50 PM
Unknown Object (File)
Wed, May 24, 7:37 PM
Unknown Object (File)
Wed, May 24, 8:02 AM
Unknown Object (File)
Mon, May 22, 3:05 PM
Unknown Object (File)
Fri, May 19, 11:55 AM
Unknown Object (File)
Thu, May 18, 11:12 PM
Unknown Object (File)
Thu, May 18, 8:35 PM
View All Files
Subscribers
None

Details

Reviewers
• schrockn
alangenfeld
• dgibson
• prha
• sandyryza
Commits
R1:e2b7333ac668: Use compat layer for typing introspection
Summary

Use a backport of the python 3.8 typing.get_args and typing.get_origin APIs to clarify our type introspection. Adds tests to clarify current behavior.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
typing-compat
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• max created this revision.May 25 2021, 5:28 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 5:49 PM
Harbormaster failed remote builds in B31151: Diff 38317!
• max updated this revision to Diff 38339.May 25 2021, 7:25 PM

py3.7

• max added a reviewer: • sandyryza.May 25 2021, 7:26 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 7:44 PM
Harbormaster failed remote builds in B31167: Diff 38339!
• max updated this revision to Diff 38385.May 25 2021, 10:04 PM

up

• max updated this revision to Diff 38387.May 25 2021, 10:10 PM

rebase

Harbormaster completed remote builds in B31200: Diff 38385.May 25 2021, 10:24 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 10:32 PM
Harbormaster failed remote builds in B31202: Diff 38387!
• max updated this revision to Diff 38401.May 25 2021, 11:04 PM

rebase on D8104

Harbormaster completed remote builds in B31213: Diff 38401.May 25 2021, 11:26 PM
• max requested review of this revision.May 25 2021, 11:26 PM
• max updated this revision to Diff 38415.May 25 2021, 11:29 PM

rebase

Harbormaster completed remote builds in B31224: Diff 38415.May 25 2021, 11:52 PM
alangenfeld accepted this revision.May 26 2021, 4:29 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/seven/typing.py
2

nit: its a little odd to me to route this through seven if seven is not doing the compat work

This revision is now accepted and ready to land.May 26 2021, 4:29 PM
• max added inline comments.May 26 2021, 4:54 PM
python_modules/dagster/dagster/seven/typing.py
2

i just want it in one place in case we want to change things -- the compat library is good but there are still nits and there are likely to be more in future

Closed by commit R1:e2b7333ac668: Use compat layer for typing introspection (authored by • max). · Explain WhyMay 26 2021, 4:55 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:e2b7333ac668: Use compat layer for typing introspection.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
seven/
1 line
utils/
115 lines
dagster_tests/
general_tests/
utils_tests/
58 lines
1 line

Diff 38339

View Options

python_modules/dagster/dagster/seven/typing.py

Loading...
View Options

python_modules/dagster/dagster/utils/typing_api.py

Loading...
View Options

python_modules/dagster/dagster_tests/general_tests/utils_tests/test_typing_api.py

Loading...
View Options

python_modules/dagster/setup.py

Loading...