Page MenuHomeElementl

[dagit] Don't show Asset alert if `asOf` points to latest
ClosedPublic

Authored by dish on Tue, May 25, 5:07 PM.

Details

Summary

When loading an asset materialization view, load the most recent materialization so that we can compare it to the asOf value, if any.

If there is an asOf value and the asOf materialization and most recent materializations have unequal timestamps, show the Alert. Otherwise, we're looking at the most recent materialization and do not need to show the Alert.

There is an unrelated issue in which asOf is not inclusive, which will be fixed separately.

Test Plan

View asset with:

  • asOf parameter that is known to be prior to the latest materialization. Verify Alert.
  • asOf parameter that is in the future. Verify no Alert.
  • No asOf parameter. Verify no Alert.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish retitled this revision from [dagit] Redirect Asset view if `asOf` points to latest to [dagit] Don't show Asset alert if `asOf` points to latest.Tue, May 25, 5:07 PM
dish requested review of this revision.Tue, May 25, 5:16 PM
This revision is now accepted and ready to land.Tue, May 25, 5:20 PM