Page MenuHomeElementl

TestStepHandler wait for processes to exit

Authored by johann on May 25 2021, 4:35 PM.
Referenced Files
Unknown Object (File)
Fri, May 26, 10:06 AM
Unknown Object (File)
Sat, May 20, 5:59 PM
Unknown Object (File)
May 10 2023, 10:45 AM
Unknown Object (File)
Apr 11 2023, 9:00 AM
Unknown Object (File)
Mar 30 2023, 9:02 PM
Unknown Object (File)
Mar 29 2023, 10:39 PM
Unknown Object (File)
Mar 17 2023, 9:35 PM
Unknown Object (File)
Mar 16 2023, 8:16 AM



This test formerly exited once a STEP_SUCCESS event was emitted for every step. However there is a gap between when a step worker emits that event, and when the step worker's process exits. This caused flakes on windows, where processes cannot still be alive when a test exits.

Test Plan

existing test

Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable

Event Timeline

johann edited the summary of this revision. (Show Details)
johann edited the test plan for this revision. (Show Details)
johann added reviewers: dgibson, max.

i'm not sure whether BK windows works - I push to github and then it automatically kicks off an azure run


the issue is happening inside the instance_for_test() teardown so you'll want this before that happens

This revision now requires changes to proceed.May 25 2021, 6:50 PM

looks good assuming it passes in azure

This revision is now accepted and ready to land.May 25 2021, 7:17 PM
This revision was landed with ongoing or failed builds.May 25 2021, 8:05 PM
This revision was automatically updated to reflect the committed changes.