Differential D8081

TestStepHandler wait for processes to exit
ClosedPublic
Actions

Authored by • johann on May 25 2021, 4:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 26, 10:06 AM

	Unknown Object (File)
	Sat, May 20, 5:59 PM

	Unknown Object (File)
	May 10 2023, 10:45 AM

	Unknown Object (File)
	Apr 11 2023, 9:00 AM

	Unknown Object (File)
	Mar 30 2023, 9:02 PM

	Unknown Object (File)
	Mar 29 2023, 10:39 PM

	Unknown Object (File)
	Mar 17 2023, 9:35 PM

	Unknown Object (File)
	Mar 16 2023, 8:16 AM

View All 90 Files

Subscribers

None

Details

Reviewers

• dgibson
• max

Commits

R1:c9fe06a4ca64: TestStepHandler wait for processes to exit

Summary

This test formerly exited once a STEP_SUCCESS event was emitted for every step. However there is a gap between when a step worker emits that event, and when the step worker's process exits. This caused flakes on windows, where processes cannot still be alive when a test exits.

Test Plan

existing test

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• johann created this revision.May 25 2021, 4:35 PM

• johann published this revision for review.May 25 2021, 4:37 PM

• johann edited the summary of this revision. (Show Details)

• johann edited the test plan for this revision. (Show Details)

• johann added reviewers: • dgibson, • max.

Harbormaster failed remote builds in B31140: Diff 38302!May 25 2021, 4:56 PM

mypy

Harbormaster failed remote builds in B31157: Diff 38324!May 25 2021, 6:00 PM

i'm not sure whether BK windows works - I push to github and then it automatically kicks off an azure run

python_modules/dagster/dagster_tests/core_tests/engine_tests/test_step_delegating_executor.py
101	the issue is happening inside the instance_for_test() teardown so you'll want this before that happens

This revision now requires changes to proceed.May 25 2021, 6:50 PM

• johann edited the test plan for this revision. (Show Details)May 25 2021, 7:15 PM

up

looks good assuming it passes in azure

This revision is now accepted and ready to land.May 25 2021, 7:17 PM

Harbormaster failed remote builds in B31164: Diff 38336!May 25 2021, 7:38 PM

This revision was landed with ongoing or failed builds.May 25 2021, 8:05 PM

Closed by commit R1:c9fe06a4ca64: TestStepHandler wait for processes to exit (authored by • johann). · Explain Why

This revision was automatically updated to reflect the committed changes.

• johann added a commit: R1:c9fe06a4ca64: TestStepHandler wait for processes to exit.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster_tests/

core_tests/

engine_tests/

test_step_delegating_executor.py

36 lines

Diff 38356

python_modules/dagster/dagster_tests/core_tests/engine_tests/test_step_delegating_executor.py

Loading...