After this change the workspace field is the one top-level place to get the current set of workspace location entries.
Details
Details
BK, reload repo location and workspace in dagit
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
note to self, still need to fix DagsterGraphQLClient.reload_repository_location (the fact that no tests are failing is troubling)
Comment Actions
Not sure what our back-compat preservation strategy is for the python client, particularly since it's so new... is it OK to swap out the underlyint query for reloadRepositoryLocation here (and just delete the old snapshot from the python client backcompat tests)?
Comment Actions
Yes, the snapshot was just to ensure that something would break if the graphql schema changes in such a way that the query is no longer valid. Once the client is using the new query, there is no reason to have the old snapshot anymore (as a new one is generated from the new query)
Requesting changes since confused on whether there might be more stuff to review since the diff is not being compared to master
| python_modules/dagster-graphql/dagster_graphql/schema/external.py | ||
|---|---|---|
| 298–299 | Is this stacked on something that hasn't been landed? This is not on master Should this be added to types? | |
Comment Actions
rebase
| python_modules/dagster-graphql/dagster_graphql/schema/external.py | ||
|---|---|---|
| 299 | WorkspaceConnection was renamed to Workspace in a previous diff, now landed | |
| js_modules/dagit/packages/core/src/graphql/schema.graphql | ||
|---|---|---|
| 758 | also fixed this embarassing typo | |