Page MenuHomeElementl
Differential D8054

[docs] Schedule testing section, put schedule examples under test
ClosedPublic
Actions

Authored by • cdecarolis on May 24 2021, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 22, 12:47 PM
Unknown Object (File)
Tue, Jan 17, 12:16 AM
Unknown Object (File)
Mon, Jan 9, 5:21 PM
Unknown Object (File)
Jan 3 2023, 8:29 PM
Unknown Object (File)
Dec 29 2022, 12:53 PM
Unknown Object (File)
Dec 25 2022, 7:23 PM
Unknown Object (File)
Dec 19 2022, 8:03 AM
Unknown Object (File)
Dec 17 2022, 6:27 PM
View All 66 Files
Subscribers
alangenfeld
• dgibson

Details

Reviewers
• sandyryza
• yuhan
Commits
R1:9a848b133845: [docs] Schedule testing section, put schedule examples under test
Summary

Add testing section for schedules, put schedule examples under test.

Test Plan

test docs build

Screen Shot 2021-05-24 at 1.33.47 PM.png (633×1 px, 150 KB)

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• cdecarolis created this revision.May 24 2021, 5:04 PM
Harbormaster completed remote builds in B31057: Diff 38197.May 24 2021, 5:26 PM
• cdecarolis requested review of this revision.May 24 2021, 5:26 PM
• cdecarolis planned changes to this revision.May 24 2021, 5:27 PM

Still a lot of work to do here; putting schedule examples under test and screenshot build

• cdecarolis retitled this revision from Schedule testing section to [docs] Schedule testing section.May 24 2021, 5:28 PM
• cdecarolis retitled this revision from [docs] Schedule testing section to [docs] Schedule testing section, put schedule examples under test.May 24 2021, 5:34 PM
• cdecarolis edited the summary of this revision. (Show Details)
• cdecarolis edited the test plan for this revision. (Show Details)
• cdecarolis updated this revision to Diff 38200.May 24 2021, 5:37 PM
• cdecarolis edited the test plan for this revision. (Show Details)

Put examples under test, fix errors

Harbormaster completed remote builds in B31060: Diff 38200.May 24 2021, 5:58 PM
• yuhan added inline comments.May 24 2021, 9:54 PM
docs/content/concepts/partitions-schedules-sensors/schedules.mdx
144

similar comment as D8058 - dont think instance_for_test is a public api

• sandyryza added subscribers: • dgibson, alangenfeld.May 25 2021, 4:19 AM
• sandyryza added inline comments.
docs/content/concepts/partitions-schedules-sensors/schedules.mdx
145

I know this isn't directly relevant to this diff, but reading this now makes me feel like get_execution_data is a weird name. "execution" and "data" are both extremely general terms, and "execute" normally has a different meaning in Dagster. Also, "get" implies that we're accessing some attribute, rather than triggering some arbitrarily complex computation. Thoughts on renaming this to something like do_tick? @alangenfeld or @dgibson might have opinions.

Also, whatever we name it, it's not included in the apidoc, so would be good to add it.

• cdecarolis added inline comments.May 25 2021, 3:42 PM
docs/content/concepts/partitions-schedules-sensors/schedules.mdx
145

that makes a lot of sense to me as well. get_execution_data is confusing at best, misleading at worst, imo, without really telling you what the function is doing.

• cdecarolis added inline comments.May 25 2021, 3:43 PM
docs/content/concepts/partitions-schedules-sensors/schedules.mdx
145

Related: ScheduleExecutionContext also feels like a rough name. Execution seems like it doesn't add anything, or fit into our meaning of execution.

• sandyryza added inline comments.May 25 2021, 3:46 PM
docs/content/concepts/partitions-schedules-sensors/schedules.mdx
145

Agree. Maybe ScheduleTickContext or ScheduleContext?

• cdecarolis edited the test plan for this revision. (Show Details)May 27 2021, 3:17 PM
• cdecarolis updated this revision to Diff 38534.May 27 2021, 3:17 PM
• cdecarolis edited the test plan for this revision. (Show Details)

Update with instance-optional changes

• cdecarolis updated this revision to Diff 38538.May 27 2021, 3:30 PM

Up

Harbormaster failed remote builds in B31307: Diff 38534!May 27 2021, 3:38 PM
Harbormaster failed remote builds in B31311: Diff 38538!May 27 2021, 3:48 PM
• cdecarolis updated this revision to Diff 38560.May 27 2021, 4:38 PM

Up

Harbormaster completed remote builds in B31329: Diff 38560.May 27 2021, 5:00 PM
• sandyryza accepted this revision.May 28 2021, 6:46 PM
This revision is now accepted and ready to land.May 28 2021, 6:46 PM
Closed by commit R1:9a848b133845: [docs] Schedule testing section, put schedule examples under test (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyMay 28 2021, 7:43 PM
This revision was automatically updated to reflect the committed changes.
Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:9a848b133845: [docs] Schedule testing section, put schedule examples under test.

Revision Contents
Changeset List

PathSize
docs/
content/
api/
concepts/
partitions-schedules-sensors/
34 lines
2 lines
sphinx/
sections/
api/
apidocs/
2 lines
examples/
docs_snippets/
docs_snippets/
concepts/
partitions_schedules_sensors/
schedules/
52 lines
docs_snippets_tests/
concepts_tests/
partitions_schedules_sensors_tests/
41 lines

Diff 38661

View Options

docs/content/api/modules.json

Loading...
View Options

docs/content/api/searchindex.json

Loading...
View Options

docs/content/api/sections.json

Loading...
View Options

docs/content/concepts/partitions-schedules-sensors/schedules.mdx

Loading...
View Options

docs/content/concepts/partitions-schedules-sensors/sensors.mdx

Loading...
View Options

docs/sphinx/sections/api/apidocs/schedules-sensors.rst

Loading...
View Options

examples/docs_snippets/docs_snippets/concepts/partitions_schedules_sensors/schedules/schedule_examples.py

Loading...
View Options

examples/docs_snippets/docs_snippets_tests/concepts_tests/partitions_schedules_sensors_tests/test_schedules.py

Loading...