Page MenuHomeElementl

New GraphQL connection for repository locations that includes display metadata and a timestamp
ClosedPublic

Authored by dgibson on Mon, May 24, 4:47 PM.

Details

Summary

Rather than using a gross union of location+error+loading, keep a consistent type that represents an entry in the workspace. This gives us a good place to attach things like timestamp, display metadata, and load status that stays the same whether or not hte locaito nloaded or not.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, May 24, 5:10 PM
Harbormaster failed remote builds in B31052: Diff 38192!
This revision is now accepted and ready to land.Tue, May 25, 12:31 AM
js_modules/dagit/packages/core/src/graphql/schema.graphql
744–746

nit: the setup of workspaceOrError -> WorkspaceConnection feels a odd - I would lean in towards Workpace with this first field returning entries

type Workspace {
  entries: [WorkspaceLocationEntry!]!
  # other info someday?
}