Page MenuHomeElementl

Fix non-thread-safe calls to Workspace.repository_locations and WorkspaceProcessContext.repository_locations
ClosedPublic

Authored by dgibson on May 24 2021, 3:05 PM.

Details

Summary

These are the last two lingering non-thread-safe methods on Workspace (I think). Using these methods runs the risk that a background thread will be messing with the list of repository_locations under the hood. Instead, require callers (almost none exist outside of tests - workspace telemetry appears to be the only 'real' one) to create a request context .

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 3:30 PM
Harbormaster failed remote builds in B31042: Diff 38179!
Harbormaster failed remote builds in B31043: Diff 38180!
This revision is now accepted and ready to land.May 25 2021, 5:57 PM