Page MenuHomeElementl
Differential D8048

[dagit] Track GanttChart mode in localStorage
ClosedPublic
Actions

Authored by • dish on May 24 2021, 2:39 PM.
Tags
None
Referenced Files
F2777280: D8048.id38228.diff
Wed, Feb 8, 5:12 PM
F2777193: D8048.id38170.diff
Wed, Feb 8, 3:37 PM
Unknown Object (File)
Mon, Feb 6, 10:18 AM
Unknown Object (File)
Sun, Feb 5, 9:51 AM
Unknown Object (File)
Jan 3 2023, 5:02 PM
Unknown Object (File)
Nov 17 2022, 11:23 PM
Unknown Object (File)
Nov 17 2022, 11:23 PM
Unknown Object (File)
Nov 17 2022, 11:22 PM
View All 60 Files
Subscribers
• jordansanders

Details

Reviewers
• bengotow
Commits
R1:becde933d6ca: [dagit] Track GanttChart mode in localStorage
Summary

Track GanttChart view mode in localStorage so that it persists across runs.

Converted GanttChart to be an FC with the ref behavior moved into an effect, so it wouldn't hurt to patch this in and poke at it if you have some time, just to sanity check.

Test Plan

View Run in Dagit, verify that the Gantt renders properly. Change view mode, refresh page. Verify that the mode has persisted correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.May 24 2021, 2:39 PM
Harbormaster completed remote builds in B31034: Diff 38170.May 24 2021, 2:50 PM
• dish requested review of this revision.May 24 2021, 2:50 PM
• bengotow accepted this revision.May 24 2021, 8:01 PM
This revision is now accepted and ready to land.May 24 2021, 8:01 PM
• bengotow added a comment.May 24 2021, 8:01 PM

Patched this down and played with it a bit to make sure the useRefs are working properly, looks good to me!

Closed by commit R1:becde933d6ca: [dagit] Track GanttChart mode in localStorage (authored by • dish). · Explain WhyMay 24 2021, 8:11 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:becde933d6ca: [dagit] Track GanttChart mode in localStorage.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
gantt/
4 lines
190 lines
28 lines
runs/
4 lines

Diff 38228

View Options

js_modules/dagit/packages/core/src/gantt/GanttChart.stories.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/gantt/GanttChart.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/gantt/useGanttChartMode.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/runs/Run.tsx

Loading...