Page MenuHomeElementl

[dagit] Track GanttChart mode in localStorage
ClosedPublic

Authored by dish on May 24 2021, 2:39 PM.
Tags
None
Referenced Files
F2777280: D8048.id38228.diff
Wed, Feb 8, 5:12 PM
F2777193: D8048.id38170.diff
Wed, Feb 8, 3:37 PM
Unknown Object (File)
Mon, Feb 6, 10:18 AM
Unknown Object (File)
Sun, Feb 5, 9:51 AM
Unknown Object (File)
Jan 3 2023, 5:02 PM
Unknown Object (File)
Nov 17 2022, 11:23 PM
Unknown Object (File)
Nov 17 2022, 11:23 PM
Unknown Object (File)
Nov 17 2022, 11:22 PM

Details

Summary

Track GanttChart view mode in localStorage so that it persists across runs.

Converted GanttChart to be an FC with the ref behavior moved into an effect, so it wouldn't hurt to patch this in and poke at it if you have some time, just to sanity check.

Test Plan

View Run in Dagit, verify that the Gantt renders properly. Change view mode, refresh page. Verify that the mode has persisted correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 24 2021, 8:01 PM

Patched this down and played with it a bit to make sure the useRefs are working properly, looks good to me!