This will put us on current mypy (0.812)
Details
Details
- Reviewers
• dgibson alangenfeld • schrockn • prha - Commits
- R1:ba312cad7c04: Upgrade mypy
Summary
Test Plan
Unit
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- upgrade-mypy
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 12:57 AM2021-05-24 00:57:41 (UTC+0)
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 2:19 AM2021-05-24 02:19:18 (UTC+0)
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 4:46 AM2021-05-24 04:46:33 (UTC+0)
Harbormaster failed remote builds in B31051: Diff 38191!May 24 2021, 5:08 PM2021-05-24 17:08:47 (UTC+0)
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 5:14 PM2021-05-24 17:14:47 (UTC+0)
Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 7:48 PM2021-05-25 19:48:57 (UTC+0)
Harbormaster failed remote builds in B31177: Diff 38353!May 25 2021, 8:14 PM2021-05-25 20:14:22 (UTC+0)
Harbormaster failed remote builds in B31180: Diff 38359!May 25 2021, 8:33 PM2021-05-25 20:33:40 (UTC+0)
Harbormaster failed remote builds in B31182: Diff 38361!May 25 2021, 8:38 PM2021-05-25 20:38:00 (UTC+0)
Harbormaster failed remote builds in B31184: Diff 38363!May 25 2021, 8:45 PM2021-05-25 20:45:18 (UTC+0)
Harbormaster completed remote builds in B31189: Diff 38370.May 25 2021, 9:05 PM2021-05-25 21:05:22 (UTC+0)
Harbormaster failed remote builds in B31201: Diff 38386!May 25 2021, 10:28 PM2021-05-25 22:28:41 (UTC+0)
Harbormaster failed remote builds in B31212: Diff 38400!May 25 2021, 11:24 PM2021-05-25 23:24:51 (UTC+0)
Harbormaster completed remote builds in B31218: Diff 38408.May 25 2021, 11:36 PM2021-05-25 23:36:02 (UTC+0)
Harbormaster completed remote builds in B31222: Diff 38413.May 25 2021, 11:50 PM2021-05-25 23:50:30 (UTC+0)
Comment Actions
Looks fine to me...
are there any advantages / features enabled that we should be aware of?
This revision is now accepted and ready to land.May 26 2021, 3:37 PM2021-05-26 15:37:38 (UTC+0)
Closed by commit R1:ba312cad7c04: Upgrade mypy (authored by • max). · Explain WhyMay 26 2021, 4:55 PM2021-05-26 16:55:26 (UTC+0)
This revision was automatically updated to reflect the committed changes.