Page MenuHomeElementl

Upgrade mypy
ClosedPublic

Authored by max on May 24 2021, 12:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 5, 9:25 AM
Unknown Object (File)
Sun, Dec 4, 11:09 PM
Unknown Object (File)
Thu, Dec 1, 2:44 PM
Unknown Object (File)
Sat, Nov 26, 1:04 PM
Unknown Object (File)
Sat, Nov 26, 7:33 AM
Unknown Object (File)
Wed, Nov 23, 6:52 PM
Unknown Object (File)
Wed, Nov 23, 2:35 PM
Unknown Object (File)
Mon, Nov 21, 10:21 AM
Subscribers
None

Details

Summary

This will put us on current mypy (0.812)

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
upgrade-mypy
Lint
Lint Errors
SeverityLocationCodeMessage
Errorpython_modules/dagster/dagster/cli/workspace/context.py:88E0601Used Before Assignment
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 12:57 AM
Harbormaster failed remote builds in B31029: Diff 38163!
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 2:19 AM
Harbormaster failed remote builds in B31030: Diff 38164!
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 4:46 AM
Harbormaster failed remote builds in B31031: Diff 38165!
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 5:14 PM
Harbormaster failed remote builds in B31053: Diff 38193!
Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 7:48 PM
Harbormaster failed remote builds in B31168: Diff 38340!

Looks fine to me...

are there any advantages / features enabled that we should be aware of?

This revision is now accepted and ready to land.May 26 2021, 3:37 PM
This revision was automatically updated to reflect the committed changes.