Page MenuHomeElementl
Differential D8047

Upgrade mypy
ClosedPublic
Actions

Authored by • max on May 24 2021, 12:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 1, 11:30 PM
Unknown Object (File)
Thu, Jun 1, 7:30 PM
Unknown Object (File)
Sun, May 28, 2:21 AM
Unknown Object (File)
Sat, May 27, 7:05 AM
Unknown Object (File)
Fri, May 26, 6:44 AM
Unknown Object (File)
Thu, May 18, 1:29 PM
Unknown Object (File)
Thu, May 18, 11:55 AM
Unknown Object (File)
Tue, May 16, 1:30 PM
View All Files
Subscribers
None

Details

Reviewers
• dgibson
alangenfeld
• schrockn
• prha
Commits
R1:ba312cad7c04: Upgrade mypy
Summary

This will put us on current mypy (0.812)

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
upgrade-mypy
Lint
Lint Errors
SeverityLocationCodeMessage
Errorpython_modules/dagster/dagster/cli/workspace/context.py:88E0601Used Before Assignment
Unit
No Test Coverage

Event Timeline

• max created this revision.May 24 2021, 12:37 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 12:57 AM
Harbormaster failed remote builds in B31029: Diff 38163!
• max updated this revision to Diff 38164.May 24 2021, 1:56 AM

dupes

Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 2:19 AM
Harbormaster failed remote builds in B31030: Diff 38164!
• max updated this revision to Diff 38165.May 24 2021, 4:24 AM

dupes

Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 4:46 AM
Harbormaster failed remote builds in B31031: Diff 38165!
• max updated this revision to Diff 38191.May 24 2021, 4:47 PM

up

• max updated this revision to Diff 38193.May 24 2021, 4:53 PM

up

Harbormaster failed remote builds in B31051: Diff 38191!May 24 2021, 5:08 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 24 2021, 5:14 PM
Harbormaster failed remote builds in B31053: Diff 38193!
• max updated this revision to Diff 38340.May 25 2021, 7:31 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 7:48 PM
Harbormaster failed remote builds in B31168: Diff 38340!
• max updated this revision to Diff 38353.May 25 2021, 7:52 PM

up

• max updated this revision to Diff 38359.May 25 2021, 8:12 PM

rebase

Harbormaster failed remote builds in B31177: Diff 38353!May 25 2021, 8:14 PM
• max updated this revision to Diff 38361.May 25 2021, 8:19 PM

mypy fixes

• max updated this revision to Diff 38363.May 25 2021, 8:24 PM

up

• max updated this revision to Diff 38365.May 25 2021, 8:27 PM

upup

Harbormaster failed remote builds in B31180: Diff 38359!May 25 2021, 8:33 PM
Harbormaster failed remote builds in B31182: Diff 38361!May 25 2021, 8:38 PM
• max updated this revision to Diff 38370.May 25 2021, 8:43 PM

omgwtf

Harbormaster failed remote builds in B31184: Diff 38363!May 25 2021, 8:45 PM
Harbormaster failed remote builds in B31185: Diff 38365!
Harbormaster completed remote builds in B31189: Diff 38370.May 25 2021, 9:05 PM
• max requested review of this revision.May 25 2021, 9:05 PM
• max updated this revision to Diff 38386.May 25 2021, 10:10 PM

rebase

Harbormaster failed remote builds in B31201: Diff 38386!May 25 2021, 10:28 PM
• max updated this revision to Diff 38400.May 25 2021, 11:03 PM

rebase on D8104

• max updated this revision to Diff 38408.May 25 2021, 11:14 PM

blk

Harbormaster failed remote builds in B31212: Diff 38400!May 25 2021, 11:24 PM
• max updated this revision to Diff 38413.May 25 2021, 11:27 PM

blk

Harbormaster completed remote builds in B31218: Diff 38408.May 25 2021, 11:36 PM
Harbormaster completed remote builds in B31222: Diff 38413.May 25 2021, 11:50 PM
• prha accepted this revision.May 26 2021, 3:37 PM

Looks fine to me...

are there any advantages / features enabled that we should be aware of?

This revision is now accepted and ready to land.May 26 2021, 3:37 PM
Closed by commit R1:ba312cad7c04: Upgrade mypy (authored by • max). · Explain WhyMay 26 2021, 4:55 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:ba312cad7c04: Upgrade mypy.

Revision Contents
Changeset List

PathSize
.buildkite/
dagster-buildkite/
dagster_buildkite/
5 lines
mypy/
5 lines
python_modules/
dagster/
dagster/
cli/
workspace/
12 lines
2 lines
dagster_tests/
cli_tests/
workspace_tests/
multi_file_target_workspace/
example_one/
1 line
example_two/
1 line
general_tests/
py3_tests/
4 lines

Diff 38363

View Options

.buildkite/dagster-buildkite/dagster_buildkite/module_build_spec.py

Loading...
View Options

mypy/config

Loading...
View Options

python_modules/dagster/dagster/cli/workspace/context.py

Loading...
View Options

python_modules/dagster/dagster/cli/workspace/workspace.py

Loading...
View Options

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/multi_file_target_workspace/example_one/pipelines.py

Loading...
View Options

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/multi_file_target_workspace/example_two/pipelines.py

Loading...
View Options

python_modules/dagster/dagster_tests/general_tests/py3_tests/test_type_examples_py3.py

Loading...