Page MenuHomeElementl
Differential D8044

Simplify built-in type system
ClosedPublic
Actions

Authored by max on May 22 2021, 11:29 PM.

Details

Reviewers
schrockn
sandyryza
dgibson
alangenfeld
prha
Commits
R1:ba68fb3102a5: Simplify built-in type system
Summary

This is necessary for compliance with current mypy, which distinguishes between type aliases (valid as annotations) and type variables (invalid as annotations).

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max created this revision.May 22 2021, 11:29 PM
max updated this revision to Diff 38154.May 22 2021, 11:39 PM

up

max updated this revision to Diff 38155.May 22 2021, 11:39 PM

rebase

Harbormaster failed remote builds in B31021: Diff 38153!May 22 2021, 11:51 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 22 2021, 11:59 PM
Harbormaster failed remote builds in B31022: Diff 38154!
Harbormaster failed remote builds in B31023: Diff 38155!
max updated this revision to Diff 38156.May 23 2021, 1:13 AM

test

Harbormaster returned this revision to the author for changes because remote builds failed.May 23 2021, 1:34 AM
Harbormaster failed remote builds in B31024: Diff 38156!
max updated this revision to Diff 38158.May 24 2021, 12:10 AM

pin alembic

Harbormaster completed remote builds in B31026: Diff 38158.May 24 2021, 12:33 AM
max requested review of this revision.May 24 2021, 12:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 24 2021, 12:37 AM
Closed by commit R1:ba68fb3102a5: Simplify built-in type system (authored by max). · Explain Why
This revision was automatically updated to reflect the committed changes.
max added a commit: R1:ba68fb3102a5: Simplify built-in type system.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
28 lines
config/
5 lines
core/
types/
5 lines
dagster_tests/
core_tests/
11 lines

Diff 38162

View Options

python_modules/dagster/dagster/builtins.py

Loading...
View Options

python_modules/dagster/dagster/config/field.py

Loading...
View Options

python_modules/dagster/dagster/core/types/dagster_type.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/test_intermediate_storage.py

Loading...