Details
Header parsing logic was tested both manually (by replacing the jwt_token in test with the one provided by the user) and by creating a similar X-Amzn-Oidc-Data header to the one used by the user.
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Will this example be explicitly mentioned in the docs somewhere?
| examples/run_attribution/run_attribution/custom_run_coordinator.py | ||
|---|---|---|
| 14–24 ↗ | (On Diff #38721) | nit: prefer early returns to avoid nesting hell |
| examples/run_attribution/run_attribution_tests/test_custom_run_coordinator.py | ||
| 34–38 ↗ | (On Diff #38721) | to avoid nesting |
| examples/run_attribution/setup.py | ||
| 4 ↗ | (On Diff #38721) | |
This example needs to show up in the docs somewhere, probably in https://docs.dagster.io/deployment/run-coordinator. Similar to https://docs.dagster.io/deployment/guides/docker#example, we should highlight the fact that a custom run coordinator can be used, and that an example is a run coordinator that injects run tags.
looks fine, maybe remove the patch on warnings?
| examples/run_attribution_example/run_attribution_example_tests/test_custom_run_coordinator.py | ||
|---|---|---|
| 25–27 | patching the warnings out feels weird.. this shouldn't affect the test behavior right? | |