unit
Details
Details
- Reviewers
alangenfeld - Group Reviewers
Restricted Project - Commits
- R1:021cc034dea5: Create Scheduler GraphQL interface
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| js_modules/dagit/src/schema.graphql | ||
|---|---|---|
| 305 | wat | |
| 757 | this seems accidental? | |
| python_modules/dagster-graphql/dagster_graphql/implementation/scheduler/system_cron_scheduler.py | ||
| 29 |
| |
| 90–98 | actually i would consider just adding file_path as a property to RunSchedule that doesnt get exposed to graphql | |
| python_modules/dagster-graphql/dagster_graphql/implementation/scheduler/system_cron_scheduler.py | ||
|---|---|---|
| 90–98 | I think it might be best to leave it to the Scheduler implementation, since other implementations won't won't need file paths, will need to store multiple file paths, or use a database, etc. For ex: I'll need to add a path to the cron shell script for this scheduler. | |
Comment Actions
Remove timestamp from schedule filenames, removing the need for a wrapper around schedules in SystemCronScheduler
| js_modules/dagit/src/schema.graphql | ||
|---|---|---|
| 757 | is String right here? we just send the json blob? | |
| python_modules/dagster-graphql/dagster_graphql/schema/run_schedule.py | ||
| 10–11 | maybe use a string instead of 1? not sure how beneficial it actually is, depends where the value actually shows up | |
| 117 | might be worth having a slightly different name since this returns a string that needs to get json decoded by the client | |
| js_modules/dagit/src/schema.graphql | ||
|---|---|---|
| 757 | I think so. I don't see a situation where you would want to get just a part of the execution params, and I don't see a way to make it query-able since the structure changes based on config. | |