[helm] Adding configurable RunCoordinator (1/n)
ClosedPublic
Actions

Authored by • sidkmenon on May 21 2021, 5:42 PM.

Details

Reviewers

• rexledesma
• johann

Commits

R1:7ff15b52b407: [helm] Adding configurable RunCoordinator (1/n)

Summary

By adding a configurable RunCoordinator to the helm chart, users will able to accomplish run attribution or specify custom hooks when a run is submitted.

Test Plan

Added tests to ensure that new schema elements (i.e. RunCoordinator module/class etc.) render correctly.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• sidkmenon created this revision.May 21 2021, 5:42 PM

• sidkmenon held this revision as a draft.

Harbormaster completed remote builds in B30993: Diff 38121.May 21 2021, 6:04 PM

Adding schema_tests

Harbormaster completed remote builds in B30999: Diff 38129.May 21 2021, 8:11 PM

• sidkmenon edited the test plan for this revision. (Show Details)Jun 1 2021, 3:28 PM

• sidkmenon added a reviewer: • johann.

• sidkmenon published this revision for review.Jun 1 2021, 3:32 PM

• sidkmenon edited the test plan for this revision. (Show Details)

• sidkmenon added a child revision: D8043: [examples] Adding a Run Attribution Example via a Custom Run Coordinator.Jun 1 2021, 3:34 PM

• rexledesma accepted this revision.Jun 1 2021, 3:39 PM

This revision is now accepted and ready to land.Jun 1 2021, 3:39 PM

nit, should change the config name in values.yaml and the schema

helm/dagster/values.yaml
778

An alternative approach would be to to remove the 'enabled' field and switch to the pattern we're using for the run launcher- the DefaultRunCoordinator is equivalent to current enabled:false. I'm ok with this setup though.

Sid correctly pointed out that both of the above suggestions are breaking changes. He'll file an issue so that we can address in 0.12. lgtm

Closed by commit R1:7ff15b52b407: [helm] Adding configurable RunCoordinator (1/n) (authored by Sidharth Menon <menon.sid.k@gmail.com>). · Explain WhyJun 3 2021, 6:54 PM

This revision was automatically updated to reflect the committed changes.

Sidharth Menon <menon.sid.k@gmail.com> added a commit: R1:7ff15b52b407: [helm] Adding configurable RunCoordinator (1/n).