Paths

Table of Contentst

Differential D8011

[dagit] Strict TypeScript
ClosedPublic
Actions

Authored by • dish on May 20 2021, 3:23 PM.

Details

Reviewers

• bengotow

Commits

R1:5e9f69bbad1d: [dagit] Strict TypeScript

Summary

Enable strict: true in dagit tsconfigs.

Test Plan

Run ts in both app and core.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dish created this revision.May 20 2021, 3:23 PM

• dish added a parent revision: D7994: [dagit] Some Util cleanup.May 20 2021, 3:23 PM

Harbormaster completed remote builds in B30892: Diff 37991.May 20 2021, 3:32 PM

• dish requested review of this revision.May 20 2021, 3:32 PM

Rebase

Harbormaster completed remote builds in B31074: Diff 38217.May 24 2021, 7:13 PM

Wow this is more minimal than I would have expected actually!

This revision is now accepted and ready to land.May 24 2021, 7:24 PM

Closed by commit R1:5e9f69bbad1d: [dagit] Strict TypeScript (authored by • dish). · Explain WhyMay 24 2021, 7:36 PM

This revision was automatically updated to reflect the committed changes.

• dish added a commit: R1:5e9f69bbad1d: [dagit] Strict TypeScript.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

app/

tsconfig.json

2 lines

core/

src/

app/

AppError.tsx

9 lines

DirectGraphQLSubscription.ts

6 lines

LocalStorage.tsx

2 lines

gantt/

GanttChart.tsx

4 lines

RunGroupPanel.tsx

65 lines

graph/

SVGComponents.tsx

5 lines

nav/

RepositoryContentList.tsx

7 lines

partitions/

PartitionRunMatrix.tsx

5 lines

RunTagsTokenizingField.tsx

2 lines

runs/

ComputeLogContent.tsx

2 lines

ComputeLogProvider.tsx

4 lines

LogsProvider.tsx

2 lines

LogsScrollingTable.tsx

2 lines

Run.tsx

2 lines

RunsFilter.tsx

2 lines

getRunFilterProviders.ts

2 lines

search/

useRepoSearch.tsx

15 lines

ui/

ButtonLink.stories.tsx

3 lines

ButtonLink.tsx

2 lines

MetadataTable.tsx

5 lines

workspace/

WorkspaceContext.tsx

2 lines

useReloadWorkspace.tsx

7 lines

tsconfig.json

2 lines

Diff 38222

View Options

js_modules/dagit/packages/app/tsconfig.json

View Options

js_modules/dagit/packages/core/src/app/AppError.tsx

View Options

js_modules/dagit/packages/core/src/app/DirectGraphQLSubscription.ts

View Options

js_modules/dagit/packages/core/src/app/LocalStorage.tsx

View Options

js_modules/dagit/packages/core/src/gantt/GanttChart.tsx

View Options

js_modules/dagit/packages/core/src/gantt/RunGroupPanel.tsx

View Options

js_modules/dagit/packages/core/src/graph/SVGComponents.tsx

View Options

js_modules/dagit/packages/core/src/nav/RepositoryContentList.tsx

View Options

js_modules/dagit/packages/core/src/partitions/PartitionRunMatrix.tsx

View Options

js_modules/dagit/packages/core/src/partitions/RunTagsTokenizingField.tsx

View Options

js_modules/dagit/packages/core/src/runs/ComputeLogContent.tsx

View Options

js_modules/dagit/packages/core/src/runs/ComputeLogProvider.tsx

View Options

js_modules/dagit/packages/core/src/runs/LogsProvider.tsx

View Options

js_modules/dagit/packages/core/src/runs/LogsScrollingTable.tsx

View Options

js_modules/dagit/packages/core/src/runs/Run.tsx

View Options

js_modules/dagit/packages/core/src/runs/RunsFilter.tsx

View Options

js_modules/dagit/packages/core/src/runs/getRunFilterProviders.ts

View Options

js_modules/dagit/packages/core/src/search/useRepoSearch.tsx

View Options

js_modules/dagit/packages/core/src/ui/ButtonLink.stories.tsx

View Options

js_modules/dagit/packages/core/src/ui/ButtonLink.tsx

View Options

js_modules/dagit/packages/core/src/ui/MetadataTable.tsx

View Options

js_modules/dagit/packages/core/src/workspace/WorkspaceContext.tsx

View Options

js_modules/dagit/packages/core/src/workspace/useReloadWorkspace.tsx

View Options

js_modules/dagit/packages/core/tsconfig.json

[dagit] Strict TypeScriptClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38222

js_modules/dagit/packages/app/tsconfig.json

js_modules/dagit/packages/core/src/app/AppError.tsx

js_modules/dagit/packages/core/src/app/DirectGraphQLSubscription.ts

js_modules/dagit/packages/core/src/app/LocalStorage.tsx

js_modules/dagit/packages/core/src/gantt/GanttChart.tsx

js_modules/dagit/packages/core/src/gantt/RunGroupPanel.tsx

js_modules/dagit/packages/core/src/graph/SVGComponents.tsx

js_modules/dagit/packages/core/src/nav/RepositoryContentList.tsx

js_modules/dagit/packages/core/src/partitions/PartitionRunMatrix.tsx

js_modules/dagit/packages/core/src/partitions/RunTagsTokenizingField.tsx

js_modules/dagit/packages/core/src/runs/ComputeLogContent.tsx

js_modules/dagit/packages/core/src/runs/ComputeLogProvider.tsx

js_modules/dagit/packages/core/src/runs/LogsProvider.tsx

js_modules/dagit/packages/core/src/runs/LogsScrollingTable.tsx

js_modules/dagit/packages/core/src/runs/Run.tsx

js_modules/dagit/packages/core/src/runs/RunsFilter.tsx

js_modules/dagit/packages/core/src/runs/getRunFilterProviders.ts

js_modules/dagit/packages/core/src/search/useRepoSearch.tsx

js_modules/dagit/packages/core/src/ui/ButtonLink.stories.tsx

js_modules/dagit/packages/core/src/ui/ButtonLink.tsx

js_modules/dagit/packages/core/src/ui/MetadataTable.tsx

js_modules/dagit/packages/core/src/workspace/WorkspaceContext.tsx

js_modules/dagit/packages/core/src/workspace/useReloadWorkspace.tsx

js_modules/dagit/packages/core/tsconfig.json

[dagit] Strict TypeScript
ClosedPublic
Actions

Revision Contents
Changeset List