Page MenuHomeElementl

prettier daemon names when they're not in the hard-coded list
ClosedPublic

Authored by dgibson on Thu, May 20, 1:38 AM.

Details

Summary

Rather than DAEMON_TYPE, call it Daemon Type. (Keeping special-casing QUEUED_RUN_COORDINATOR)

Test Plan

View dagit with extra daemons, see nicer looking names

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson published this revision for review.Thu, May 20, 1:48 AM
dgibson added a reviewer: prha.

the build error looks legit?

prha requested changes to this revision.Thu, May 20, 5:25 AM
This revision now requires changes to proceed.Thu, May 20, 5:25 AM

this seems to fix? (ESNext.string)

This revision is now accepted and ready to land.Thu, May 20, 3:44 PM