Fix permalinks
ClosedPublic
Actions

Authored by • max on May 19 2021, 12:45 AM.

Tags

None

Referenced Files

	F2988801: D7975.diff
	Mon, Jun 5, 2:31 AM

	Unknown Object (File)
	Thu, May 11, 4:57 PM

	Unknown Object (File)
	Sun, May 7, 12:36 PM

	Unknown Object (File)
	Sat, May 6, 11:18 PM

	Unknown Object (File)
	Sat, May 6, 1:36 PM

	Unknown Object (File)
	Apr 28 2023, 9:13 AM

	Unknown Object (File)
	Apr 22 2023, 8:43 AM

	Unknown Object (File)
	Apr 6 2023, 8:34 AM

View All 68 Files

Subscribers

None

Details

Reviewers

• dgibson
• sidkmenon

Commits

R1:390adbb1686a: Fix permalinks

Summary

This walks back D7910 to fix permalink reloading

Test Plan

Manual

Diff Detail

Repository

R1 dagster

Branch

fix-permalinks

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	python_modules/dagit/dagit/app.py:193	W0613	Unused Argument
Warning	python_modules/dagit/dagit/app.py:193	W0613	Unused Argument

Unit

No Test Coverage

Event Timeline

• max created this revision.May 19 2021, 12:45 AM

maybe fix lint before you push? otw lgtm.

• sidkmenon accepted this revision.May 19 2021, 12:48 AM

This revision is now accepted and ready to land.May 19 2021, 12:48 AM

This revision was landed with ongoing or failed builds.May 19 2021, 12:52 AM

Closed by commit R1:390adbb1686a: Fix permalinks (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: R1:390adbb1686a: Fix permalinks.

Harbormaster failed remote builds in B30786: Diff 37866!May 19 2021, 1:06 AM

Harbormaster failed remote builds in B30788: Diff 37868!May 19 2021, 1:10 AM

• max mentioned this in D7977: Fix asserts.May 19 2021, 1:55 AM

• max mentioned this in R1:8927f6c4bbf4: Fix asserts.May 19 2021, 1:59 AM

Revision Contents
Changeset List

Path

Size

python_modules/

dagit/

app.py

4 lines

Diff 37866

View Options

python_modules/dagit/dagit/app.py

Fix permalinksClosedPublicActions