Page MenuHomeElementl

[dagit] Turn on eqeqeq lint rule
ClosedPublic

Authored by dish on May 18 2021, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 22, 12:48 PM
Unknown Object (File)
Sun, Jan 15, 11:09 PM
Unknown Object (File)
Sat, Jan 14, 7:13 PM
Unknown Object (File)
Sun, Jan 8, 5:19 PM
Unknown Object (File)
Fri, Dec 30, 4:04 PM
Unknown Object (File)
Dec 23 2022, 6:45 PM
Unknown Object (File)
Dec 22 2022, 9:24 AM
Unknown Object (File)
Dec 2 2022, 1:04 PM
Subscribers
None

Details

Summary

Enable eqeqeq lint rule with "error" configuration, ignoring null checks (which I'm not crazy about, but don't feel strongly about).

Test Plan

yarn lint

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bengotow added inline comments.
js_modules/dagit/packages/core/.eslintrc.js
25

Hmm interesting this wasn't there already actually, and isn't part of the recommended set... I feel like I see these == -> === warnings in most React projects. Good catch!

This revision is now accepted and ready to land.May 18 2021, 4:18 PM
This revision was automatically updated to reflect the committed changes.