Page MenuHomeElementl
Differential D7963

[dagit] Turn on eqeqeq lint rule
ClosedPublic
Actions

Authored by • dish on May 18 2021, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 22, 12:48 PM
Unknown Object (File)
Sun, Jan 15, 11:09 PM
Unknown Object (File)
Sat, Jan 14, 7:13 PM
Unknown Object (File)
Sun, Jan 8, 5:19 PM
Unknown Object (File)
Fri, Dec 30, 4:04 PM
Unknown Object (File)
Dec 23 2022, 6:45 PM
Unknown Object (File)
Dec 22 2022, 9:24 AM
Unknown Object (File)
Dec 2 2022, 1:04 PM
View All 53 Files
Subscribers
None

Details

Reviewers
• bengotow
Commits
R1:0d63d23fa014: [dagit] Turn on eqeqeq lint rule
Summary

Enable eqeqeq lint rule with "error" configuration, ignoring null checks (which I'm not crazy about, but don't feel strongly about).

Test Plan

yarn lint

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.May 18 2021, 2:52 PM
Harbormaster completed remote builds in B30722: Diff 37775.May 18 2021, 3:03 PM
• dish requested review of this revision.May 18 2021, 3:03 PM
• bengotow accepted this revision.May 18 2021, 4:18 PM
• bengotow added inline comments.
js_modules/dagit/packages/core/.eslintrc.js
25

Hmm interesting this wasn't there already actually, and isn't part of the recommended set... I feel like I see these == -> === warnings in most React projects. Good catch!

This revision is now accepted and ready to land.May 18 2021, 4:18 PM
Closed by commit R1:0d63d23fa014: [dagit] Turn on eqeqeq lint rule (authored by • dish). · Explain WhyMay 18 2021, 4:33 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:0d63d23fa014: [dagit] Turn on eqeqeq lint rule.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
app/
1 line
core/
1 line
src/
app/
2 lines
assets/
2 lines
configeditor/
codemirror-yaml/
2 lines
gantt/
2 lines
instance/
2 lines
jobs/
2 lines
2 lines
nav/
4 lines
partitions/
5 lines
runs/
2 lines
2 lines
schedules/
2 lines
4 lines
6 lines
sensors/
2 lines

Diff 37789

View Options

js_modules/dagit/packages/app/.eslintrc.js

Loading...
View Options

js_modules/dagit/packages/core/.eslintrc.js

Loading...
View Options

js_modules/dagit/packages/core/src/app/AppProvider.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/assets/AssetLineageElements.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/configeditor/codemirror-yaml/lint.js

Loading...
View Options

js_modules/dagit/packages/core/src/gantt/toGraphQueryItems.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/instance/InstanceBackfills.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/jobs/LiveTickTimeline.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/jobs/TickHistory.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/nav/RepositoryLocationStateObserver.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/partitions/PartitionsBackfill.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/runs/LogsRowStructuredContent.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/runs/RunActionButtons.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/schedules/SchedulePartitionStatus.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/schedules/SchedulerInfo.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/schedules/SchedulesNextTicks.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/sensors/SensorInfo.tsx

Loading...