Page MenuHomePhabricator

Fix dagster-aws CloudWatch tests
ClosedPublic

Authored by natekupp on Aug 11 2019, 1:03 AM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:623b35f6fcbe: Fix dagster-aws CloudWatch tests
Summary

Also had to manually attach arn:aws:iam::aws:policy/CloudWatchLogsFullAccess to the buildkite roles to make this work (one more reason we should get this all in pulumi...)

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Aug 11 2019, 1:03 AM
natekupp edited the summary of this revision. (Show Details)Aug 11 2019, 1:15 AM
natekupp added a reviewer: Restricted Project.
Harbormaster completed remote builds in B2870: Diff 3589.
schrockn accepted this revision.Aug 11 2019, 4:53 PM
schrockn added a subscriber: schrockn.
schrockn added inline comments.
python_modules/libraries/dagster-aws/dagster_aws_tests/cloudwatch_tests/test_loggers.py
95

I actually did this exact thing in a branch too.

This is fine for now but could we do something more reliable like polling?

This revision is now accepted and ready to land.Aug 11 2019, 4:53 PM
natekupp updated this revision to Diff 3592.Aug 11 2019, 11:16 PM

add polling

This revision was automatically updated to reflect the committed changes.