Page MenuHomeElementl

dagster-graphql custom transport and execution tags
ClosedPublic

Authored by owen on Mon, May 17, 9:04 PM.

Details

Summary

allow for users to use a custom transport for their dagster graphql client, and add a tags parameter to the submit_pipeline_execution method

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, May 17, 9:25 PM
Harbormaster failed remote builds in B30681: Diff 37728!
owen requested review of this revision.Mon, May 17, 10:39 PM
rexledesma added a subscriber: rexledesma.
rexledesma added inline comments.
python_modules/dagster-graphql/dagster_graphql/client/client.py
63–64

let's use check here, as this will be supplied by the user

98

we should also validate the tags as well

This revision now requires changes to proceed.Tue, May 18, 2:28 AM

landable, but note validate tags in an issue if you choose not to resolve it here

This revision is now accepted and ready to land.Tue, May 18, 6:05 PM

validate the tags that are passed in