Page MenuHomeElementl
Differential D7912

[dagit] Fix config nubs
ClosedPublic
Actions

Authored by • dish on May 14 2021, 2:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 24, 9:15 PM
Unknown Object (File)
Tue, Mar 21, 3:28 PM
Unknown Object (File)
Mon, Mar 20, 10:19 PM
Unknown Object (File)
Sat, Mar 18, 8:59 PM
Unknown Object (File)
Fri, Mar 10, 8:39 PM
Unknown Object (File)
Feb 19 2023, 9:11 AM
Unknown Object (File)
Feb 13 2023, 2:45 AM
Unknown Object (File)
Jan 31 2023, 6:12 AM
View All 59 Files
Subscribers
None

Details

Reviewers
• bengotow
• prha
Commits
R1:0d007e0fb186: [dagit] Fix config nubs
Summary

Resolves #4138

A recent change made it so that the DAG viewer rendered config nubs on every solid, instead of just solids with configs. Repair this by skipping the nub for any solids with Any config.

Test Plan

View a bunch of different pipelines, verify that the config nub only appears on relevant solids.

Diff Detail

Repository
R1 dagster
Branch
dish-config-nubs
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• dish created this revision.May 14 2021, 2:29 PM
Harbormaster completed remote builds in B30574: Diff 37584.May 14 2021, 2:36 PM
• dish requested review of this revision.May 14 2021, 2:36 PM
• bengotow accepted this revision.May 14 2021, 9:47 PM
This revision is now accepted and ready to land.May 14 2021, 9:47 PM
Closed by commit R1:0d007e0fb186: [dagit] Fix config nubs (authored by • dish). · Explain WhyMay 16 2021, 10:32 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:0d007e0fb186: [dagit] Fix config nubs.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
graph/
4 lines

Diff 37584

View Options

js_modules/dagit/packages/core/src/graph/SolidNode.tsx

Loading...