Page MenuHomeElementl
Differential D7910

Use route handlers instead of 404s for routing
ClosedPublic
Actions

Authored by • max on May 13 2021, 11:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 31, 2:07 AM
Unknown Object (File)
Thu, May 25, 11:13 AM
Unknown Object (File)
Fri, May 19, 11:58 PM
Unknown Object (File)
Sun, May 14, 1:26 PM
Unknown Object (File)
Mon, May 8, 3:33 AM
Unknown Object (File)
May 2 2023, 12:49 AM
Unknown Object (File)
Apr 24 2023, 8:36 PM
Unknown Object (File)
Apr 16 2023, 2:44 AM
View All Files
Subscribers
None

Details

Reviewers
• dgibson
alangenfeld
• prha
• dish
• sashank
Commits
R1:0f11c3b25cb5: Use route handlers instead of 404s for routing
Summary

This is much easier to reason about and allows middlewares to easily rewrite route handlers.

Test Plan

Manual

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.May 13 2021, 11:59 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 14 2021, 1:03 AM
Harbormaster failed remote builds in B30564: Diff 37574!
• max updated this revision to Diff 37701.May 17 2021, 7:03 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.May 17 2021, 7:25 PM
Harbormaster failed remote builds in B30659: Diff 37701!
• max updated this revision to Diff 37707.May 17 2021, 7:28 PM

fix tests

Harbormaster returned this revision to the author for changes because remote builds failed.May 17 2021, 7:47 PM
Harbormaster failed remote builds in B30665: Diff 37707!
• max updated this revision to Diff 37719.May 17 2021, 8:21 PM

blk

Harbormaster returned this revision to the author for changes because remote builds failed.May 17 2021, 8:43 PM
Harbormaster failed remote builds in B30674: Diff 37719!
• max added a reviewer: • sashank.May 17 2021, 8:44 PM
• sashank commandeered this revision.May 17 2021, 8:45 PM
• sashank edited reviewers, added: • max; removed: • sashank.
• sashank foisted this revision upon • max.
• sashank edited reviewers, added: • sashank; removed: • max.
• max added a comment.May 17 2021, 8:46 PM

wheee

• max requested review of this revision.May 17 2021, 8:46 PM

stochastic failures from docker postgres

• sashank accepted this revision.May 17 2021, 8:46 PM
This revision is now accepted and ready to land.May 17 2021, 8:46 PM
This revision was landed with ongoing or failed builds.May 17 2021, 8:47 PM
Closed by commit R1:0f11c3b25cb5: Use route handlers instead of 404s for routing (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:0f11c3b25cb5: Use route handlers instead of 404s for routing.
• max mentioned this in D7975: Fix permalinks.May 19 2021, 12:45 AM
• max mentioned this in R1:390adbb1686a: Fix permalinks.May 19 2021, 12:52 AM

Revision Contents
Changeset List

PathSize
python_modules/
dagit/
dagit/
12 lines
dagit_tests/
10 lines

Diff 37724

View Options

python_modules/dagit/dagit/app.py

Loading...
View Options

python_modules/dagit/dagit_tests/test_smoke.py

Loading...