Page MenuHomeElementl

Use route handlers instead of 404s for routing
ClosedPublic

Authored by max on May 13 2021, 11:59 PM.

Details

Summary

This is much easier to reason about and allows middlewares to easily rewrite route handlers.

Test Plan

Manual

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 14 2021, 1:03 AM
Harbormaster failed remote builds in B30564: Diff 37574!
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, May 17, 7:25 PM
Harbormaster failed remote builds in B30659: Diff 37701!
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, May 17, 7:47 PM
Harbormaster failed remote builds in B30665: Diff 37707!
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, May 17, 8:43 PM
Harbormaster failed remote builds in B30674: Diff 37719!
sashank edited reviewers, added: max; removed: sashank.
sashank foisted this revision upon max.
sashank edited reviewers, added: sashank; removed: max.
max requested review of this revision.Mon, May 17, 8:46 PM

stochastic failures from docker postgres

This revision is now accepted and ready to land.Mon, May 17, 8:46 PM
This revision was landed with ongoing or failed builds.Mon, May 17, 8:47 PM
This revision was automatically updated to reflect the committed changes.